View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0018300 | MMW 5 | Extensions framework | public | 2021-09-14 17:26 | 2021-11-29 21:09 |
| Reporter | Ludek | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0.2 | Fixed in Version | 5.0.2 | ||
| Summary | 0018300: Add Promise.finally() as replacement of Promise.then1() | ||||
| Description | Per IM discussion we should add also 'finally' (as replacement of then1) and replace it in code (though keeping then1 still available just in case any addon uses it). https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/finally | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2503 | ||||
|
|
Added Promise.finally() method (as duplicate of then1 and used already in some parts of code), but seeing that we are using 'then1' on many places in code -- and I am afraid that bulk replacing would require quite extensive test coverage to be sure that there are no regressions. So I am still leaving 'then1' as alternative (to be replaced by 'finally' in the future versions/code). |
|
|
Verified function in 2503 Not closed till Deprecation of Then1 is documented in API so that it is only provided for compatibility reasons and that Finally should be used, because it will be removed in future versions. |
|
|
Assigned back to me to update the docs. |
|
|
Promise class documented , assigned to Jiri to update the docs on the web ( https://www.mediamonkey.com/docs/api/ ) |
|
|
Uploaded updated docs. |
|
|
Verified 2507 Verified API |
