View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0018435 | MMW 5 | Tagging / organizing (properties / auto-tools) | public | 2021-10-18 15:55 | 2021-11-16 21:00 |
Reporter | rusty | Assigned To | |||
Priority | urgent | Severity | major | Reproducibility | always |
Status | closed | Resolution | reopened | ||
Product Version | 5.0.2 | ||||
Target Version | 5.0.2 | Fixed in Version | 5.0.2 | ||
Summary | 0018435: Auto-tag: Date field doesn't appear even when it has been found / apply Album Date preferentially | ||||
Description | In build 2510, auto-tag no longer fills in the date field--even when the date is displayed in the album field. Here's an example, but I was able to replicate with multiple tracks. https://www.screencast.com/t/niJ3WMCgG | ||||
Tags | No tags attached. | ||||
Fixed in build | 2520 | ||||
|
Date is filled same as before ... in album it's album date, but you meant track date ... for case when track date isn't available in the lookup we'll try to use album date instead. |
|
The MM UI (whether in Properties, Tracklists, or any other view) has 'Date' and 'Original Date'. 'Date' refers to the publication date of the disc/media upon which it's published (whether it's a compilation or a regular album), while 'Original date' refers to the date that the track was originally published. The same holds true for the Tags (ID3/Vorbis etc.) to which the Date field is mapped. But if Auto-tag is taking the MB:track release date (rather than the Album date) and using it to fill the 'Date' field (which is generally supposed to be used for the Album's date), it would conflict how the Date fields are used in the rest of the MM5 UI. The issue probably hasn't come up until now because for many tracks the MB Track date is equal to or similar to the Album date Would it make sense to use MB:AlbumDate if it exists, and ReleaseDate if it doesn't? Would it make sense if MB:AlbumDate and MB:TrackDate exist to import them into 'Date' and 'Original Date' respectively? |
|
Fixed |
|
Verified 2516 It looks like it works OK on different cases as explained in 0018435:0065641 left resolved to review any regressions before/after 5.0.2 lunch. |
|
Tested 2519, and in this build, the track in question (Never Going Home by 'Kungs') no longer finds any corresponding date! Here's the metadata: https://musicbrainz.org/artist/a125cd83-a379-4935-a7ec-beaa778bad70 Based on what I see here, I would have expected that if an album is found, the Album date should be used. If no album is found, then the date of the single should be used. |
|
Problem is that for some reason search engine on our MB server returns empty array (didn't found this record) for that track http://mb.mediamonkey.com:5000/ws/2/recording/?query=recording%3A%22Never%20Going%20Home%22%20AND%20artist%3A%22Kungs%22%20AND%20status%3AOfficial&limit=100&fmt=json |
|
Per discussion with Petr, we need to perform MB server re-index more frequently, but not too often due to it's performance hit. The agreed was once a week (to be modified in the future, probably by switch to live reindex). |
|
Fixed |
|
Verified with file from Rusty and several other Albums, Date is looked up as expected on 2520. |