|
|
Every skin can define where progresses should be visible using DIV element with data-id 'progressContainer'. When there's no element with this id, new is created at the bottom of the DOM (not in the dock) so it is ALWAYS visible at the most bottom of the main window. |
|
|
i.e. this issue is likely specific to the 'Code Monkey' skin. |
|
|
It is not only related to the CodeMonkey skin. I still see the issue with the Monkey Groove skin which is installed by default. ... tested with 2531 I will put a request into the CodeMokey thread to correct the issue. The issue is debilitating because there is no way to cancel a sync operation unless you know the trick re the bottom Player panel visibility. In skins that don't have have this problem the current implementation is fairly ugly ... ie. the status bar overwrites other data, and is hard to read. See attached image. "When there's no element with this id, new is created at the bottom of the DOM (not in the dock) so it is ALWAYS visible at the most bottom of the main window." I don't fully understand all what is quoted above, but the statement seems false to me. ... ie. nothing is visible in CodeMonkey and Monkey Groove. |
|
|
The author of the CodeMonkey skin responded https://www.mediamonkey.com/forum/viewtopic.php?p=493462#p493462 It seems as if there is in inadequacy in the MM skin framework that hampers skins from delivering a reliable and readable status bar for long running background task. I took the liberty of re-opening the issue because it seems like comments to closed issues are invisible. It seems to me that a response of "no change required" is inadequate. 1. A long running batch task requires a status bar so the User can see sign of life, and monitor progress , and to gain access to the Cancel option... It is illogical that this be available contingent upon the Player panel be on display. 2. The Status bar is available on the default skin, when the Playing screen is disabled, but the status bar is illegible and is ugly (see attached pix) 3. The Monkey Groove has no Status bar when the Playing panel is disabled 4. The response is "When there's no element with this id, new is created at the bottom of the DOM (not in the dock) so it is ALWAYS visible at the most bottom of the main window." ... maybe I misunderstand, but if this statement was true, why don't I see this created thing in the Monkey Groove and CodeMonkey skins? 4. Reportedly the see existing framework creates difficulty for Sking authors, see TIV73's comments in the above link. status bar is overwritting.png (52,682 bytes) |
|
|
I believe the most important thing is to allow the user to right click > Cancel all on the tasks controller on the top bar. This I can do. Next, I believe it's up to the skin maker whether they want their task progress container to be inside the player or not. The issues Barry brought up are valid, and I think it's worth changing our bundled skins to make the task progress bar always visible, on the bottom of the screen. I'll take this issue and try to add both. |
|
|
Fixed in 5.0.3; updated Dark Monkey release on addons site. To fix the ugly clipping issue, the task progress bar now has its own area on the bottom of the screen when any are visible. This can be disabled by skin makers by adding the following code in controls/taskscontroller_add.js: TasksController.prototype.override({ initialize: function ($super, parentEl, params) { $super(parentEl, params); this.squeezeWindowContent = false; } }); The Material Design skin has a more advanced example, disabling squeezeWindowContent only when the player is visible and on the bottom dock (which is the default state). |
|
|
OK, thanks. "allow the user to right click > Cancel all on the tasks controller on the top bar. This I can do." This happens after I get 5.0.3? ... ATM (2531) I am unable to cancel a sync using anything at the top (menu bar, Tool bar etc, and the spinning wheel has no Context Menu item to achieve this) , using your new version of Dark Monkey ... Expected? Am I missing something? |
|
|
2531 is a 5.0.2 build. However, the context menu addition in 5.0.3.2603 caused a crash as described in 0018240. Should be resolved in the next build. |
|
|
Also can look at the issue I raised here also please; https://www.mediamonkey.com/forum/viewtopic.php?p=494127#p494127 The text in the new Status bar can get overwritten if there is a task running in the background. I don't know whether this is a framework, or a skin issue ... or is WAD . ? |
|
|
drakinite: see my answer to your question here: https://www.mediamonkey.com/forum/viewtopic.php?p=494180#p494180 |
|
|
Barry has confirmed that it was resolved in 2605. |
|
|
Verified 2605 I can also confirm. |
- Anonymous
