0019157: Problems with deleteFolderAsync method

ID	Project	Category	View Status	Date Submitted	Last Update

0019157	MMW 5	Extensions framework	public	2022-06-06 19:20	2022-08-15 11:16

Reporter	zvezdan	Assigned To
Priority	high	Severity	minor	Reproducibility	N/A
Status	closed	Resolution	fixed
Target Version	5.0.4	Fixed in Version	5.0.4

Summary	0019157: Problems with deleteFolderAsync method
Description	1. deleteFolderAsync method should not remove records from the Songs table, even if they have SongPath with removed folder. At least add one new argument that could prevent that. 2. deleteFolderAsync method should not remove folders having non-media files if onlyEmpty argument is true. At least add one new argument that will determine which folders could be removed ("only if the folder has no other non-media content" or "only if completely empty").
Tags	No tags attached.

Fixed in build	2658

Ludek 2022-07-21 11:45 developer ~0068864 Last edited: 2022-07-21 11:45	1. OK, added dontDeleteFromDB optional param for the next 5.0.4 build image.png (22,866 bytes) image.png (22,866 bytes)

Ludek 2022-07-21 11:45 developer ~0068865	2. I checked the code and if onlyEmpty is TRUE then MM5 isn't deleting the folder at all in case there is a subfolder (or a non-media file). Could you please share example folder than MM5 deletes although it shouldn't (when onlyEmpty is TRUE) so that I can replicate and fix ?

zvezdan 2022-07-21 12:07 updater ~0068866	2. I cannot reproduce it, even with the version that was actual when I posted the issue. Sorry, I suppose I did something wrong. By the way, your API description is complicated and somewhat confusing. You should just say: "Only if the folder is empty" or more specifically "Only if the folder has no files and sub-folders" without mentioning any "other" or "non-media" or "content".

Ludek 2022-08-15 11:16 developer ~0069006	"Only if the folder has no files and sub-folders" without mentioning "non-media content" does not make sense --> as this method just deletes the folder so how could the folder became non-empty after deletion? The point here is that MediaMonkey deletes only the media content by default (music, video, artwork) and the onlyEmpty argument preserves the non-media files.