0019812: Sync confirmation dialog appears even when disabled (regression)

ID	Project	Category	View Status	Date Submitted	Last Update

0019812	MMA	Synchronization	public	2023-02-13 18:55	2023-07-03 19:54

Reporter	rusty	Assigned To
Priority	urgent	Severity	minor	Reproducibility	always
Status	closed	Resolution	reopened
Product Version	2.0.0
Target Version	2.0.0	Fixed in Version	2.0.0

Summary	0019812: Sync confirmation dialog appears even when disabled (regression)
Description	If the user disables Sync Settings > Delete from the device:Confirm (show confirmation dialog) --> Upon initiating a sync operation the confirmation dialog still whenever new tracks are being synced to the device If it's disabled (and there are no updates from the device to MMW to confirm), then the dialog should not appear. -- Note for the future: we may want to modify MMA so that the user can also configure the 'Show confirmation dialog' option associated with Device --> Library updates (currently this is only configurable in MMW).
Additional Information	Log ID: LV5KY3TVPD https://www.mediamonkey.com/forum/viewtopic.php?t=103826 Ticket 5948 https://www.mediamonkey.com/forum/viewtopic.php?t=104418
Tags	No tags attached.

Fixed in build	1093

rusty 2023-03-01 19:26 administrator ~0071276 Last edited: 2023-03-14 01:01	User report at https://www.mediamonkey.com/forum/viewtopic.php?t=103826 Also reported at ticket 5589

rusty 2023-03-28 16:01 administrator ~0071407	Additional report at https://www.mediamonkey.com/forum/viewtopic.php?t=103954 (issue 9)

rusty 2023-06-22 19:59 administrator ~0072323	Another reason why this is problematic is that the functionality to externally initiate sync operations is intended to allow for automatic synchronization, but currently, this bug prevents that functionality from being fully automated.

martin 2023-06-28 12:48 developer ~0072363	Fixed in build 2.0.0.1092

peke 2023-06-30 19:53 developer ~0072380	Verified 1092

rusty 2023-06-30 22:40 administrator ~0072383 Last edited: 2023-07-01 00:16	Tested synchronization on an S8 (syncing to an SD card/internal sync disabled), and it resulted in the confirmation screen still appearing albeit with the confirmation checkboxes not showing! See image below. This is worse than the original bug as it's still not possible to initiate confirmationless synchronization, but in addition, now the user doesn't even know what they're confirming. Debug log: M31XQCX8HA meaningless-confirmation-screen.jpg (32,269 bytes) meaningless-confirmation-screen.jpg (32,269 bytes)

martin 2023-07-02 13:25 developer ~0072388	Fixed in build 2.0.0.1093

rusty 2023-07-03 19:54 administrator ~0072398	Verified 1093.

related to	0020032	closed	martin	Launching MediaMonkey playlists or synchronization from another app doesn't work (regression)
related to	0020112	closed	martin	Sync app shortcut doesn't adhere to sync settings