View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020193 | MMW 5 | General | public | 2023-08-15 05:45 | 2023-08-20 16:50 |
Reporter | drakinite | Assigned To | |||
Priority | normal | Severity | tweak | Reproducibility | N/A |
Status | assigned | Resolution | reopened | ||
Product Version | 5.1 | ||||
Target Version | 5.2 | ||||
Summary | 0020193: "flags" property included in asJSON / toJSON but is not published | ||||
Description | Reported here: https://www.mediamonkey.com/forum/viewtopic.php?t=104637 The flags property of TSongListData (Track) is included in JSON outputted by asJSON, but it is a "public" property instead of a "published" property, meaning it's not accessible to JS, also meaning that it's not included in the API docs. We may wish to either remove it from asJSON or make it a published property. FYI: I did a quick filter for keys that are included in asJSON but not accessible in the original track's JS object and found these: - idAlbum (the original JS object is capitalized differently; namely 'idalbum') - dateF (What's this for?) - bitRate (the original JS object is capitalized differently; namely 'bitrate') - tempString (What's this for?) (lyrics and comments of course are in the list too, but I believe those two are self explanatory so don't need any changes.) | ||||
Tags | No tags attached. | ||||
Fixed in build | |||||
|
|
|
Seeing that Michal added flags in course of fixing 0019790 , I suppose that this kind of info is needed for input plugins. Similarly the values like tempString might be needed in device plugins. 'dateF' is same as 'date', just in different format, currently read by d_iPhone.dll and d_iPod.dll 'tempString' is also used for transfering value(s) to d_iPhone.dll and d_iPod.dll while syncing I don't think that these values should be published.. they are rather for internal purposes |
|
Is it worth documenting those properties somewhere? Maybe as a note in the asJSON tsdoc - any other ideas? |