View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0020666 | MMW 5 | Other | public | 2024-02-26 08:01 | 2024-04-17 14:45 |
| Reporter | michal | Assigned To | |||
| Priority | immediate | Severity | block | Reproducibility | unable to reproduce |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.1 | ||||
| Target Version | 5.0.5 | Fixed in Version | 5.0.5 | ||
| Summary | 0020666: Artwork lookup sometimes stops working for some users | ||||
| Description | Some users have problem with artwork lookup, it stops working suddenly. It seems to be related to some wrong data in Chromium cache files, we currently do not know how this happens and how to at least simulate this state. Workaround for this problem, which seems to work for all users - delete folder C:\Users\<username>\AppData\Local\Temp\GPUCache This is temporary folder, where Chromium stores its data including result of cookies consent dialog. For now we need at least KB article describing this workaround. | ||||
| Additional Information | https://www.mediamonkey.com/forum/viewtopic.php?p=517351 https://www.mediamonkey.com/forum/viewtopic.php?t=105748 Ticket 7008, 7009, 7011, 7012 https://github.com/electron/electron/issues/40366#issuecomment-1789075486 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2695 | ||||
|
|
Seems to be Chromium issue and deleting GPUCache is only workaround, until they fix it. https://issues.chromium.org/issues/40267041 |
|
|
So shouldn't we clean the GPUCache folder whenever we detect that image lookup isn't working? |
|
|
We cannot reproduce it, so detection of this is problematic (lookup can fail for multiple reasons, not only this). Also app has to be restarted after the folder remove. The issue should be fixed in Chromium 121. Unfortunately, we use 120. We should consider to upgrade at least this one version up. |
|
|
I've implemented chromium commit https://chromium-review.googlesource.com/c/angle/angle/+/5197906 (should contain fix of this issue) into chromium 120. |
|
|
User reports, that the fix did not help :-/ https://www.mediamonkey.com/forum/viewtopic.php?p=517835#p517835 |
|
|
I just experienced this, but can't figure out how to replicate. It's a really serious issue, though, as it's not even obvious that MM is broken, and the current workaround is overly technical. If we can't fix this OR detect this state automatically and automatically clear the cache as Ludek suggested at 0020666:0074372, perhaps a workaround would be to: - Halt the lookup if no results appear after ?30?s. - Then display something like. Unknown error: _Clean cache_ (a link) - If the user clicks the _Clean cache_ link, then MM should clear the cache and after doing so, prompt the user to "MediaMonkey needs to be restarted to apply the changes" [[Restart]] [Cancel] Note: all of these strings already exist. |
|
|
This seems to be the best what we can offer right now. In order to not show the error message too often and in situations when it shouldn't be shown, we could e.g. try to find out whether the internet connection works well or anything else that would narrow down the cause of why search doesn't work at the moment. |
|
|
I've added callback to loadError, implemented method to restart with cache cleanup. Assiging to Michal to apply in artwork lookup. |
|
|
Fixed in build 3007. We now detect known network errors and display toast message in such cases (typically existing string "There is a problem with your internet connection."). In case of some unknown problem, in case result is not known for 30s, we display suggested error message with possibility to restart app with cleaning cache. |
|
|
The dialog "Unknown error" can be displayed sometimes unintentionally, especially when automatic lookup in grid is on and user scrolls through items without artwork. Dialog should also have some title, as it can be shown outside image lookup dialog, e.g. title "Lookup image" (existing string), so context of the message will be more clear. |
|
|
Fixed in build 3008. |
|
|
Album Art lookup is failing regularly in 3010. Using the 'Clean cache' function / restart has no effect. See the attached log showing a lookup for 'The Beatles' 'Abbey Road' and subsequent failure after cleaning the cache/restarting. |
|
|
For me, it worked, but I had to clean cache again and again and experienced also crashes during closing app. Logs sent to Petr. |
|
|
Fixed |
|
|
Fixed in build 3012. |
|
|
Script made more universal and stable, it currently disables Google search in older versions, where it cannot work (before 2024.0.0.3012), and displays standard addon not compatible message, if used in older not supported versions. |
|
|
Fixed in 2024.0.0.3013, merged to 5.0.5.2695. |
|
|
Verified on 5.0.5 Artwork is found in Preview (Playing/Selected), Info Panel (Artist/Album), Playing node (Artist/Album/Lyrics), Properties (Artwork lookup) and Auto-Tag. |
