0020986: Selecting all tracks from same album do not suggest filling missing album artist information in multi edit properties - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0020986	MMW 5	Tagging / organizing (properties / auto-tools)	public	2024-06-04 19:16	2024-06-20 16:41

Reporter	peke	Assigned To
Priority	urgent	Severity	minor	Reproducibility	always
Status	assigned	Resolution	open
Product Version	5.1
Target Version	5.1.1

Summary	0020986: Selecting all tracks from same album do not suggest filling missing album artist information in multi edit properties
Description	Before fixing 0016388 when User had missing Album artist on some tracks from an album Multi Edit properties pre selected fields that had at least one track with missing information, which can lead to accidental wrong tagging. That works in 99.99% of cases except where user wants to multi edit tags to fill that information exept where Artist+Album are same and some tracks are missing Album artist NOTE: Artist and Album Artists columns are not bot enabled in list views by default so it is easy to miss missing Album artists on part of an album.
Steps To Reproduce	0. Set MM to List View and make sure that Artist, Album, Album Artists columns are visible 1. Open One Album in MM -> Entire Library -> Folders -> [FULL ONE ALBUM] 2. Select Few Tracks from Album -> Properties -> Delete Album Artist -> OK Which will separate Album to Two albums NOTE: @Ludek noted it in 0020978:0075710 and he is right that FMFS correctly works. 3. If you select tracks that have/have not Album Artist -> Properties it will Show things correctly according to 0016388 eg. not selected 4. After fixing 0016388 If you select all tracks from album both with and without Album artists it will show Properties for multi edit like all tracks have same filled Album Artist and there is no way to tell that user needs to check Album Artist in order to update/correct missing information Expected If Artist+Album(Album value is not Empty) is same for all selected tracks and some selected tracks have same Album artist value (or one have value and others have Album artist empty) then Album Artist Check Box should be Selected as clicking on OK will not trigger non needed tagging or wrong tagging like pointed in 0016388, but would actually fix/fill correct information for Album artist for the whole album.
Tags	No tags attached.

Fixed in build

peke 2024-06-04 19:25 developer ~0075737	Expected Behavior in PIC5 would be that Album Artist is pre checked to fill missing information. Otherwise you do not have any feedback that some tracks have missing information and assume it is all ok like in PIC 4 and Albums would be still separated like in PIC1 (which was actually the reason for creating bug 0020978) image.png (196,701 bytes) image.png (196,701 bytes) image-2.png (24,640 bytes) image-2.png (24,640 bytes) image-3.png (62,186 bytes) image-3.png (62,186 bytes) image-4.png (55,929 bytes) image-4.png (55,929 bytes) image-5.png (71,713 bytes) image-5.png (71,713 bytes)

rusty 2024-06-19 20:44 administrator ~0076056	Peke is essentially suggesting that when it comes to 'Album Artist', that MM should special-case them and pre-check the field, on the assumption that users will always multi-select tracks from the same album. This would probably work, but the downsides of this approach are that: a) it doesn't adequately solve the problem of clearly communicating that only some of the tracks are populated with metadata b) could, in rare cases (e.g. if multiple 'Greatest Hits' albums are selected) result in tracks being unintentionally modified incorrectly c) is inconsistent with how other fields operation and with how suggested changes are communicated in other dialogs (i.e. through the use of color and '!' in Auto-tag and Tag from Filename. An alternate solution would be to: - Display an '!' in red whenever there are conflicting values for a field - When all values for a field either equal x or "", display the value in the 'suggested' color (same as used in the Auto-tag dialog, with an ! When hovering over the '!' show something like 'Conflicts with original value:' "" and "<value>" . (this is an existing string).