View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0021066 | MMW 5 | Skinning framework | public | 2024-06-28 10:27 | 2024-09-17 18:04 |
| Reporter | zvezdan | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.1 | ||||
| Target Version | 5.1 | Fixed in Version | 5.1 | ||
| Summary | 0021066: Incorrect value stored in persistent.json for skin option | ||||
| Description | Let say that I have a skin with the next info.json: { "title": "Info Test", "id": "infoTest", "description": "Info Test", "version": "1.0.0", "type": "skin", "author": "Zvezdan Dimitrijevic", "skin_options": [ { "type": "dropdown", "title": "Font size", "variable": "@testVariable", "default": "2", "options": { "1": "something (red)", "2": "anything (blue)", "3": "dropdown (green)" } } ] } An let say that I have skin_base_add.less: @testVariable: 2; body { & when (@testVariable = 1) { background: red !important; } & when (@testVariable = 2) { background: blue !important; } & when (@testVariable = 3) { background: green !important; } } If I change dropdown from the default 2-nd value to the 1-st one, I will get the next lines in the persistent.json: "infoTest_skinOptions": { "dropdown_@testVariable": "1" }, "CustomLESS_infoTest": { "values": [ "@testVariable: 1px;" ] }, Note the added "px". It seems that the program works fine with such skin even with this anomaly, but it is quite strange because (@testVariable = 1px) is not the same as (@testVariable = 1). | ||||
| Tags | No tags attached. | ||||
| Attached Files | |||||
| Fixed in build | 3037 | ||||
|
|
Yes, I think it makes sense. |
|
|
Fyi. Material Colors skin needs related fix - @baseFontSize is set without "px", which causes invisible text. Maybe we could leave automatic adding of "px" to known px variables, like @baseFontSize in this case. |
|
|
Added to build 3037. Fixed for @baseFontSize, as it is probably most used and needed. |
|
|
Tested all skins and they seem to work, resolving. |
|
|
Verified 3054 Tested on all Skins. |
