View Issue Details

IDProjectCategoryView StatusLast Update
0021135MMW 5Tagging / organizing (properties / auto-tools)public2024-08-07 14:44
Reporterpeke Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status assignedResolutionopen 
Product Version5.0 
Target Version5.1.1 
Summary0021135: Auto-Tag: Tagging new Artwork deletes all existing without any choice
DescriptionIf user Auto-Tag Album art from dialog then all existing tags are deleted that can delete better copies of AA with worst ones.

Sample File uploaded to FTP under "/MM5/builds/bug21135/".
Steps To Reproduce1. Load sample file to NP
2. Open Track Properties -> Artwork and note that Cover AA is high res and that tag contains other Artworks -> close properties
3. Right click on track -> Auto -Tag
4. Click on Artwork
5. MM AA dialog present with choice Original (500x500) Which is wrong (as seen in track properties) and one new that is same res like one in properties, defaulting new AA
6. If user clicks OK -> Tag & Continue
7. All existing Artwork in file are deleted and new AA is tagged in file.

Expected Behavior in this case is that if proposed AA (in size) is similar to Original one (guess <10% bigger than original) then Original will be selected (eg, no change is required), so that when user clicks Tag & continue Artwork tags are not changed.
TagsNo tags attached.
Fixed in build

Relationships

related to 0021136 closedpetr Auto-Tag: Tagging Artwork from Auto-Tag dialog should not delete existing additional artworks 

Activities

rusty

2024-08-07 03:43

administrator   ~0076605

Last edited: 2024-08-07 03:51

There are 2 points raised by Peke above:
1) MMW deletes existing primary artwork without notice (let's define primary as the First artwork)
2) MMW deletes all secondary artwork without notice

I'm not sure that 1) is a bug, since:
a) Updates to artwork work like updates to all other fields i.e. the proposed suggestions are adopted by default
b) The user is notified whenever there's a change to the artwork via an indicator on the proposed artwork
c) The user can switch the proposed artwork by tapping on the proposed artwork

Note: I don't think the size of the artwork is as important as the accuracy of the artwork. Also, the arguement that a larger image is better isn't necessarily true either since users often don't want tagged artwork to be too large. Nonetheless there could be an argument for a new separate feature that allows users to specify the desired size of looked up artwork.

As issue 2), I agree that it can be a problem since:
- users have no indication of what artwork is being removed
- users have no ability to retain the artwork

A possible solution to this would be:
I) change the default behavior to only replace the first artwork image (as suggested at 0021136)
II) change the artwork dialog so that it shows all the existing images as well and give the user the ability to retain/delete them
e.g.
Original            New		  |  
                                   |
_Not specified_v    _Front cover_v | _Back cover_v         _Artist_v
                                   |
 [Orig Image]        [New image]   |  [Back cover image]   [ArtistImage]
     ( )                 (o)       |      [x]                   [x]
                                   |
 . . [Lookup] [OK] [Cancel] . . .  |    [Lookup]             [Lookup]

 
III) add an auto-tag setting in the Auto-tag Options e.g.
 [x] Artwork [ Replace first image only | Replace first image and delete existing images]

This setting would determine what happens by default, and whether all secondary images are pre-checked or not (See II above)

peke

2024-08-07 14:44

developer   ~0076607

Now that 0021136 is fixed

I Still would prefer that option to retain OLD image is default in case of very similar AA found as like pointed res not guaranties of quality.
image.png (148,329 bytes)   
image.png (148,329 bytes)