View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0021207 | MMW 5 | Playlists (Auto) / Search / Filters | public | 2024-09-13 22:46 | 2024-09-16 15:05 |
Reporter | lowlander | Assigned To | |||
Priority | urgent | Severity | minor | Reproducibility | always |
Status | feedback | Resolution | duplicate | ||
Product Version | 5.1 | ||||
Target Version | 5.1.1 | ||||
Summary | 0021207: x Closes Search instead of clearing it | ||||
Description | Opened from 0012569. x closes Search, except when doing so in the Podcast Index Contextual Search | ||||
Steps To Reproduce | 1 Start search 2 Use x --> Search closes, instead of emptying user value | ||||
Tags | No tags attached. | ||||
Fixed in build | |||||
|
I think that X should close the search when typing in the view (contextual search) otherwise it would be unclear how to close accidentaly opened search bar But for the global search it should probably just clear the text.. Assigned to Rusty to review/decide.. |
|
BTW: In Chrome it also closes the 'Find bar', based on my tests whenever the search bar is not always visible then X is rather used for closing (rather than clearing).. Maybe we could add another search option like: [x] Always show search bar and in that case the X would "clear" instead of "close" ? |
|
Vivaldi browser use/show X exclusively to clear search, Chrome (Android), EGDE, Google, Bing Search Bars and many many WorkPress pages uses X for clear not close. More non clear search behaviors will be handled in 0021208 |
|
Based on the above, and as alluded to by Ludek, the approach generally taken is that: - If a search bar is persistent, then 'x' clears it - if a search bar isn't persistent, then 'x' closes it MMW doesn't currently have persistent search bars, except for the Podcast index. So the current inconsistent behavior actually makes sense i.e. - For contextual / global search bars which aren't persistent, the 'x' closes it - For Podcast index which has a persistent search bar, the 'x' clears it As Ludek suggested, we might want to consider allowing the contextual and/or global search bars to persist and if they do, then 'x' would clear results. BUT, it seems risky to start fiddling with this behavior at this stage. So my recommendation would be to defer this. |
|
ok, agreed |