View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0021299 | MMW 5 | FileMonitor / Find Missing | public | 2024-10-26 22:26 | 2024-11-05 02:10 |
| Reporter | peke | Assigned To | |||
| Priority | urgent | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | duplicate | ||
| Target Version | 5.1 | Fixed in Version | 5.1 | ||
| Summary | 0021299: Ability to rescan Library Folder | ||||
| Description | By fixing/tweaking INS key behavior in 0021285 we removed ability to Rescan library Folders using INS key on Selected track in folder. The change would be that SHIFT+INS behave same for Library track like INS key for NON-LIBRARY track (eg. @Ludek Implementation in 0021285:0077330) | ||||
| Additional Information | https://www.mediamonkey.com/forum/viewtopic.php?t=106845 https://www.mediamonkey.com/forum/viewtopic.php?t=106842 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 3071 | ||||
|
|
ok, giving the choice sounds like a good idea, i.e. SHIFT+INS always scans the pre-selected content in the view while single INS scans the 'lastly scanned' content? |
|
|
Yes, it seems that there really is a need for letting users to either: a) Scan based on scan settings b) Scan based on selected content We had attempted to address this at 0019080, but the approach there often forced b) when the user wanted a). And by reverting 0019080, MM now forces a) when some users want b). The proposal above attempts to address the need for both by offering separate shortcuts for each, HOWEVER, it results in a situation in which there's no UI for scanning selected content via a menu and most users will not even realize that such an option is available via a shortcut. Possible alternatives or improvements that would address this are: 1) A new contextual menu (in addition to the SHIFT-INSERT proposal): Find more from same > Folder (Library/Scan). This would launch the Add/Rescan dialog for the first selected track in the same manner as 0019080 and switch to the Library folder. 2) Modify the Add/Rescan dialog so that it can function in one of two ways using a radio button to choose which approach (a or b) to use: Scan the following locations for media: (.) Folder: C:/...../ (o) Folders (list) . . . . . [Add Location] ...scan list... . . . Option 2) seems preferable as it doesn't require a new shortcut, doesn't require multiple UIs for the same functionality, and would seem to satisfy all usecases, and not require any new strings. The only advantage of 1) is that the user explicitly chooses which type of scan to perform a priori, in contrast to 2) in which the user will sometimes have to switch the scan type with the radio button. |
|
|
2) I like the approach, but it clutters UI a bit and these way user is unable to select both (folders as scan settings plus selected folder).. What about to always show/keep the lastly selected folders (scan settings), and add the pre-selected path as unchecked, and once user checks the pre-selected folder then next time add it as checked, i.e. remember check state of the pre-selected folder.. plus remember check state of the scan settings (as is now when there isn't any pre-selected folder) Then both sets of users .. those using case (a) and those using case (b) should be satisfied? |
|
|
Option 3): Taking this offline and fixed (in 3068) the way that the pre-selected folder is added as first and is checked and selected/focused so that user can easily delete it either by pressing 'Del' key or clicking 'trash' button and the last used folder list selection is preserved.. Resolved for testing, but IMO it works fine without any significant downside.. |
|
|
Now we flip-flopped right back. I don't think having to constantly remove scan locations and select what you actually want scanned helps many users. Now if a file is selected, the location is pre-selected to be scanned, other locations that were selected are disabled. So a user needs to delete the new location they didn't want and re-select the location they do want. We can't solve a problem by creating a problem for other use cases, then we shouldn't solve the problem. 1 I Rate a file in the Playing 2 Use File > Add/Rescan Files to scan my unrelated incoming files folder --> Need to remove folder for file rated in Playing --> Need to re-enable the incoming folder for scanning We can't assume that selecting a file equals intent to scan its folder. Files are select for playback and editing reasons as well. I don't want to deselect folders each time I intend to scan. Others have said the same. A) I think right click on Folder/Location should add it to rescan, as well that using Shift+INS should add the selected file/folder. Otherwise using File > Add/Rescan Files and INS should not auto-add any folders for scanning. B) An alternative is to have the selected items folder auto-added, but leave it unselected, while previous folder selections remain as previously set by user. That would not interfere with users try to scan normally, while making things easier for users trying to scan a selected item. This shifts the burden for unselecting/deleting from users who didn't need this, to selecting for users who do need this (they still see an improvement as the folder is auto-listed). |
|
|
I understand LL's objection to the current implementation (Option 3), since for users who often scan based on scan settings, they're forced to deselect a folder each time. Moreover, the current approach populates the scan list with all sorts of unwanted directories--even directories that aren't scanned! If we decide to continue with Option 3, MM should: i) not pre-check auto-added folders as LL suggested at B) ii) not automatically save auto-added folders to the scan list. This is problematic with the current UI since it doesn't in any way distinguish between directories that are saved and those that are being one-time-scanned. A possible approach to dealing with this would be to add them with the schedule 'One time' (this is an existing string) so that unless the user switches it to any of the other options, it wouldn't be saved to the list. Note: if we take the approach of: Option 1) then MM should also implement the functionality 3ii) described above to prevent the scan list from being over populated Option 2), there wouldn't be a mechanism for saving auto-added scans, though I'm not sure if that would really be a problem (it would mean that directories would have to be added directly via the scan dialog). |
|
|
I think that the best solution is something along the originally proposed Option 2) (Modified Add/Rescan dialog). For a better separation of both scan types, I was thinking about 2 tabs, not sure about their names though. Possibly something like 'repeated scan' and 'one-time scan'? |
|
|
I had also thought about using two tabs but couldn't think of a way of doing so that would; - not require new strings - communicate the mutual exclusivity of the operations (it can clearly separate config options, but I want sure how to make it unambiguous that the operations are mutually exclusive) |
|
|
New strings could be an issue. Maybe for v2024 we could do it as originally proposed and in the future use tabs that'd contain radio buttons in order to make it clear that it's mutually exclusive choice? |
|
|
IMO we are unnecessarily complicating things.. Currently the scan settings is untouched, just the pre-selected folder is added as first row and can be easily deleted by one click or by pressing 'Del' In addition the advantage of current implementation is that user can add futher folders to scan settings without need to use the [Add Location...] button |
|
|
Per discussion with Ludek (and LL previously), the current approach (i.e. the implementation in build 3068) can work for both of the usecases [ a) Scan based on scan settings & b) Scan based on selected content ] if the following tweaks are made: i) MM doesn't pre-check auto-added folders (so that in usecase a) there's no need to uncheck folders each time, and for usecase b) the user can just check the folder). ii) MM doesn't save auto-added folders to the scan list, unless the user changes the schedule from 'One-time' to any of the other options and then either Scans (=Save and Scan) or Saves the list. (so that the Scan list doesn't fill up with undesired folders). |
|
|
Fixed in 3069 |
|
|
Tested scanning of one time folder and it doesn't seem to do anything. e.g. 1 Navigate to Folders > Path 2 Select a file 3 Press INS --> Scan dialog appears 4 Enable the path to the folder and disable all others 5 Scan --> Dialog closes and nothing happens Also, when initiating a scan via the Folders node, MM will sometimes set it to 'one-time' and sometimes 'manual' depending on whether the tracks are part of the library or not. The behavior should be consistent within the node. I think it would make sense for it to be 'Manual' since this is how it's always worked for Folders/Locations, but I can also see the argument that the behavior should be consistent across ALL nodes (i.e. always use 'One-time' scans by default). EDIT: upon further discussion, it would probably make more sense for the functionality to be globally consistent and always set auto-added folders for 'One-time' scans. |
|
|
Fixed in 3070 |
|
|
Verified in 3070 that when a folder is scheduled for a one-time scan that it actually gets scanned. Re-opening since the bug in which initiating a scan for a track in the Folder node sometimes triggers a one-time scan and other times triggers a (persistent) manual scan remains. |
|
|
Fixed in 3071 |
|
|
Verified 3071. |
|
|
Verified on 3071 as well. |
