0021329: Custom File Location can sync files outside selected folder - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0021329	MMW 5	Sync	public	2024-11-06 11:48	2024-11-11 19:18

Reporter	peke	Assigned To
Priority	high	Severity	minor	Reproducibility	always
Status	assigned	Resolution	open
Product Version	5.0.5
Target Version	5.2

Summary	0021329: Custom File Location can sync files outside selected folder
Description	When user creates Local folder sync device and then changes Default File location to custom one MM can sync files to folders outside Sync folder.
Steps To Reproduce	1. Create local storage sync device (s:\Temp\Sync test\) 2. Options -> File Locations change from "\Temp\Sync test\Music\<Album Artist> - <Album>\<Track #:2> $Left(<Artist>,20) - <Title>" -> "\Music\<Album Artist> - <Album>\<Track #:2> $Left(<Artist>,20) - <Title>" -> Apply 3. Do a sync and tracks are saved to S:\Music\ and not to S:\Temp\Sync test\Music\ Expected that "s:\Temp\Sync test\" is always prefix for sync folder and MASK is Applied to root sync path eg. "Music\<Album Artist> - <Album>\<Track #:2> $Left(<Artist>,20) - <Title>" -> "s:\Temp\Sync test\Music\<Album Artist> - <Album>\<Track #:2> $Left(<Artist>,20) - <Title>" "\Music\<Album Artist> - <Album>\<Track #:2> $Left(<Artist>,20) - <Title>" -> "s:\Temp\Sync test\Music\<Album Artist> - <Album>\<Track #:2> $Left(<Artist>,20) - <Title>"
Tags	No tags attached.
Attached Files	image.png (26,314 bytes) image.png (26,314 bytes)

Fixed in build

rusty 2024-11-06 13:41 administrator ~0077517 Last edited: 2024-11-06 13:45	Unless I'm misunderstanding, this seems to be a relatively minor issue. i.e. Assuming that the bug is specific to using 'Set as sync target...' (i.e. that masks work correctly for 'regular devices') and that the issue is just that File Locations aren't displayed to reflect the fact that they're actually relative to s:\Temp\Synctest', then it's a minor UI issue. can you please confirm: 1) Is this issue a regression from 5.0.5 (a quick examination of 5.0.5 seems to show that it also displays the full path in Sync > File locations even though it should only show a relative path, but I haven't tested)? 2) Does this issue occur when syncing to a USB key OR is it specific to the 'Set as sync target...' functionality?

peke 2024-11-06 16:44 developer ~0077519	Re 1) Profile is created based on absolute paths including Path to folder, but Without Drive letter where every other Sync profile reflect to Absolute path and appending Device/Service Root path as suffix to Mask, but Sync to Path only watch mask not Root path. eg if Root path c:\Temp the any changes to Mask should be c:\temp\ + DECODED MASK ("s:\Temp\Sync test\" + "\Music\<Album Artist> - <Album>\<Track #:2> $Left(<Artist>,20) - <Title>" not Drive letter of ROOT path + DECODED MASK ("s:\Music\<Album Artist> - <Album>\<Track #:2> $Left(<Artist>,20) - <Title>" Re 2) It only happens with Set Sync Path. And it is design ISSUE, User contacted me that Syncing to Folder deleted whole library on External Drive as he copied Phone Mask to folder Sync (similar to my example).

Ludek 2024-11-11 18:55 developer ~0077560 Last edited: 2024-11-11 19:12	I remember that there has been a good reason to concatenate masks with mask root, so if you change on the 'Summary' page the 'Sync root' to 'C:\my music\' then the masks are auto-concatenated to '\my music\Music\<Album Artist> - <Album>\<Track #:2> $Left(<Artist>,20) - <Title>' The only issue I see is the refresh issue atm. as changing the 'Sync root' and clicked [Apply] does not change the mask in 'Sync profile > File locations' until F5 is pressed.. i.e. the masks are in fact changed after changing the root, but the change is shown after F5 pressing or re-visiting the device progile.. As for the Peke's suggestions in functionality/design, I am not keen to do this atm as it would result in various regressions, namely root 'C:\my music\' with masks '\my music\..' would sync as target 'C:\my music\my music\..' which is unintenional..