View Issue Details

IDProjectCategoryView StatusLast Update
0021454MMW 5Tagging / organizing (properties / auto-tools)public2025-02-06 14:42
Reporterrusty Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status feedbackResolutionopen 
Product Version2024.1 
Target Version2024.2 
Summary0021454: Lyrics lookup fails (regression?)
DescriptionWhile looking at 0021450, it became apparent that lyrics lookup doesn't seem to be functioning correctly.

0 Prior to testing this: Delete lyrics from track 3 via the Properties dialog
1 Enable lyrics lookup
2 Enable the lyrics element
3 Play track 2 (has lyrics) and then track 3 (missing lyrics)
--> Lyrics fail to lookup for track 3!
I would have expected the lyrics to lookup automatically and remain in the 'unsaved' state.

Tested for the Preview window and the issue occurs there as well.
TagsNo tags attached.
Fixed in build

Relationships

related to 0021445 closedLudek Artwork not shown on playback in Preview and Playing node 
related to 0018645 closedmichal Background Metadata Lookup: lyric (and Album art) lookups are repeated after user has deleted poor results 

Activities

michal

2025-01-22 15:28

developer   ~0078035

It does not seem to be regression, Lyrics panel does not support automatic lyrics search and not saved lyrics yet, it seems. Tried 5.0.5 and it was the same.
It works for me in Preview panel, only you need to switch lyrics property on in Advanced layout settings.

michal

2025-01-22 15:53

developer   ~0078036

Oh, it suddenly started to work for me, so it is not so clear. Analyzing more.

michal

2025-01-24 10:05

developer   ~0078048

I fixed some possible problems found during code analysis, also unwanted dash could occur sometimes in lyrics field.
BUT, the main problem is caused by behavior forced in 0018645, where we wanted to stop lyrics lookup for track, if user deleted found lyrics for this track. That is what happened here. Affected tracks have set special flag, that user deleted found lyrics, so he/she is not satisfied with the search result, so we do not try to automatically search lyrics again for these tracks. We cannot distinguish whether the user deleted lyrics because he/she wants to have them searched again, or because the search results are wrong and he/she does not want to search again. I think in the first case he/she can simply use manual search after deleting lyrics, not let it on automatic search. So I guess current behavior is correct? Only could be confusing especially in such case, where you are trying to test this automatic search functionality.