View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002709 | MMW v4 | Properties/Auto-Tools | public | 2006-11-30 22:57 | 2006-12-22 19:11 |
| Reporter | jiri | Assigned To | |||
| Priority | immediate | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.5.4 | ||||
| Fixed in Version | 2.5.5 | ||||
| Summary | 0002709: .fla extension isn't supported | ||||
| Description | Sometimes FLAC uses .fla extension, but it isn't supported in MM. We should add it to f_flac.dll. However, make sure that it doesn't fail on non-FLAC files with this extension. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | |||||
|
|
Added support and tested accordingly to description and tested by renaming various type of files in either .FLAC or .FLA and then scanning them in MediaMonkey. |
|
|
I don't understand how could it possibly work? I see that you just added another 'FLAC' line to sources: OUR_FORMAT2 : TFORMAT_INFO = (extension:'FLAC'; description:'FLAC Audio'; flags:0); How do you let know MM that '.FLA' is supported? |
|
|
Ok It must be Typo, I have Reposted and F_FLAC.DPR and saved then again so that SVN catches it as modified. It should stay OUR_FORMAT2 : TFORMAT_INFO = (extension:'FLA'; description:'FLAC Audio'; flags:0); |
|
|
I still don't think it's ok, what about FORMAT_CanHandle() function, it should support both extensions too. |
|
|
Mine Line 1177 Contains: If (Not (S = Our_Format.extension)) And (Not (S = Our_Format2.extension)) Then With both formats/extension. It looks that I have some problems in SVN Cache. I've resynchronized it to be 100 sure and indeed File is modified. It's OK now. |
|
|
I created .fla files but there's no way to scan them into MM. i.e. the scan folders dialog doesn't have an option to select the .fla extension. |
|
|
Setting as urgent because this was supposed to be included with MM 2.5.5, however, if there's risk, we can defer. |
|
|
.FLA is not supported as input plugin for FLAC do not have in list of supported General->File Types. Internally F_FLAC Support it but MM do not have Input plugin allocated to .FLA. I have changed in_flac.c to include .FLA in listing. Assigning to Jiri to check if I change it correctly. |
|
|
Ok, included. |
|
|
Verified 2.5.5.988. |
