View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003078 | MMW v4 | Playlist / Search | public | 2007-05-30 13:45 | 2007-08-17 19:53 |
| Reporter | jiri | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0 | ||||
| Fixed in Version | 3.0 | ||||
| Summary | 0003078: Add new filters/query types - those that were in MM 2.5 | ||||
| Description | In MM 2.5 we had an option to filter Artist and Album nodes according to number of their tracks (e.g. show Albums with >= 8 tracks). In MM 3.0 we have much advanced filtering functionality, but these specific filters are missing because they aren't part of Advanced Queries - this should be implemented. Namely: 1. 'Artist Tracks' (number of tracks of given Artist) 2. 'Album Tracks' (number of tracks of given Album) 3. 'Artist Albums' (number of albums of given Artist) Each should have standard operators (=, <, >, <=, >=). | ||||
| Additional Information | Technical note: Since SQL for these operation could be quite time consuming (and for some other reasons too) I added fields calculated by triggers to tables Artist and Albums: Artists.Tracks, Artists.Albums, Albums.Tracks in build 1037. Therefore a very simple and fast queries can be made. Technical note 2: In memory comparisons will be quite problematic. E.g. this scenario: User has filter (Album with >5 tracks) and scans new tracks, while the first 5 tracks of album are scanned, they shouldn't be shown (e.g. when user is in Title node), but as soon as 6th track is scanned, suddently all the tracks of the album should be shown. I'm not sure if we can make anything better, but I'd suggest to ignore there operators for in-memory query handling and only support them for SQL queries - i.e. user would see correct result only after pressing F5 key, not on-line. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1060 | ||||
|
|
When this is finished, Rusty should review the wording and positions of the query operators. |
|
|
Re-opening for cosmetic tweaks: 1. Grammar changes: 'Artist Tracks' --> '# Tracks by Artist' 'Album Tracks' --> '# Tracks in Album' 'Artist Albums' --> '# Albums by Artist' 2. Default operator changes: In all cases the default operator should be '>=' 3. Order in the query list: These queries should appear after 'Tempo' and before 'Comment' 4. I also noticed a functional problem, but I'm not sure if it's fixable: -If the user adds a criterion such as '# Tracks by Artist' >=5, then, when filtering is enabled, there are often situations where a given artist will only have 3 tracks displayed, the reason being that the criteria of '# Tracks by Artist' >=5 is examined independently of the other criteria. This shouldn't be done as it yields results that can be confusing. I think that users would expect is that these criteria are performed on the result set of criteria that preceded them. Let me know what you think. |
|
|
4. A. No, this isn't easily fixable, at least in a way that would work fast. B. Although I understand that it could be confusing sometimes the way it's currently implemented, I'm not sure if it's really better the other way. It's about how the condition is understood, I see it as looking for Artists that have >5 tracks in my Library, not Artists that have >5 tracks under given conditions. The rest if for Ludek... |
|
|
1,2,3 - fixed in build 1042. |
|
|
Verified 1044. |
|
|
'# Albums by Artist' doesn't work well, the results are incorrect, as can be tested by using some mutli-artists album. It's caused by the fact that the query links over ArtistSongs table, while it should be over ArtistsAlbums table. |
|
|
I still hasn't been able to find out what Jiri means by "'# Albums by Artist' doesn't work well, the results are incorrect" After a discussion with Jiri I found out that Jiri means that it should work like '# Albums by Album Artist' instead of '# Albums by Artist'. So I fixed it in build 1060. Note: The field may want to be renamed to '# Albums by Album Artist' now, but in most cases user can't notice a difference and the title would be too long. |
|
|
Verified 1060. |
