View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003242 | MMW v4 | Synchronization | public | 2007-07-09 16:46 | 2007-08-08 11:39 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Fixed in Version | 3.0 | ||||
| Summary | 0003242: Selecting the Entire Library doesn't include library updates | ||||
| Description | User can't really select the whole Library. The selection is currently (i.e. MM 3.0) saved based on individiual artists, i.e. when a new artist is added to the Library, it isn't synched the next time! What should happen is that selecting All Artists or All Albums or All Locations, or All Genres should behave as if the user has selected 'Entire Library' (or everything that matches the active filter if filtering is implemented on this tab). Implementation Notes from Jiri if Filtering is implemented: I would suggest to save settings based on filters when user click on Artist, Album or Location node. I.e. if any of these nodes is checked (and none of their children is unchecked), MM will automatically check the other nodes too (i.e. Artist, Album and Location will all be checked) and later save (to a new DB table) that the whole current filter should be synchronized. I.e. user could select the whole Music filter to by synched, or e.g. just Classical music filter. | ||||
| Additional Information | http://www.mediamonkey.com/forum/viewtopic.php?t=18970 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1059 | ||||
|
|
Technically, I think that we should add a new DB table 'DeviceFilters' with fields IDDevice, IDFilter and SynchAll. In case Artists, Albums or Locations node is checked (doesn't matter which one, in any case all of them should get checked) a record in this table would be updated, so that upon synchronization all tracks of that filter would be synchronized. |
|
|
Ok, I've done it. The new table 'DeviceFilters' is added and check states of Artists, Albums and Locations nodes are stored in this table. (they has to be stored individually, because 'Artists' or 'Albums' node doesn't contain all tracks!, it contains all tracks except 'unknown' albums) Selected filter persists now and total size is updated after selecting another filter (because only visible items will be synchronized) I set the 'Music' filter as default. Added in build 1058. |
|
|
Ludek, I'm not sure I understand: The intent of a user selecting the top level node is to select the Entire contents of the library--including those that may have unknown Artists, Genres, Albums, etc. |
|
|
No, the current implementation is: If [x] Artists is selected it means that all its subnodes are also checked, but the [x] Unknown node is missed from the subnodes (because it is not presented) therefore selecting [x] Artists includes contents of the library except tracks with Unknown artists. On the other hand selecting of [x] Locations includes contents of the entire library, because it contains all subnodes. Is the reason more obvious? |
|
|
Assigning back to me (as discussed with Jiri over IM) to implement it originally suggested way despite the fact that 'Unknown' subnodes should be presented for Artists and Albums to ensure rightness. |
|
|
As discussed over IM, in build 1059: 1. reverted previous solution with filtering, i.e. filter tool filters only "what to show user" and not "what is going to be synched" 2. CJanged handling of checking all items so that all three root nodes would be checked at once. The original problem "Selecting the Entire Library doesn't include library updates" is of course fixed too. |
