View Issue Details

IDProjectCategoryView StatusLast Update
0003334MMW v4Properties/Auto-Toolspublic2007-07-27 20:29
Reporterjiri Assigned To 
PriorityurgentSeverityminorReproducibilitysometimes
Status closedResolutionfixed 
Product Version3.0 
Fixed in Version3.0 
Summary0003334: Auto-normalization too slow
DescriptionBased on some EurekaLogs, auto-normalization is very slow and can cause the MM appears frozen. Namely, this code in Normalization.pas seems to be causing the problem:

        PrepareSongListQuery_Full(Q);
        sql := ' WHERE (NormalizeTrack < -99999)';
        if (NormalizeAlbums) then sql := sql + ' or (NormalizeAlbum < -99999)';
        sql := sql + ' order by NormalizeTrack limit 1';
TagsNo tags attached.
Fixed in build1053

Activities

jiri

2007-07-25 16:19

administrator   ~0009922

It seems that two things would help to make this working faster:
 1. Add indexes to DB for NormalizeTrack and NormalizeAlbum fields.
 2. Use INTERSECT SQLite clause instead of 'OR' (because SQLite can't use >1 index in a single query).
 3. Remove 'order by' clause. Is it really needed there?

petr

2007-07-25 19:21

developer   ~0009928

I've made some changes in queries used in normalization, so i think now it'll be much faster. Can be tested in 1053.

rusty

2007-07-27 20:29

administrator   ~0009958

Verified that it's working correctly in 1053.