View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003683 | MMW v4 | Properties/Auto-Tools | public | 2007-09-29 09:09 | 2007-10-14 11:48 |
| Reporter | jiri | Assigned To | |||
| Priority | immediate | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0 | ||||
| Fixed in Version | 3.0 | ||||
| Summary | 0003683: Showing of multi-artist albums in the tree | ||||
| Description | Let's say we have a track T that has artist A, album artist AA (different from A) and is part of album L. Currently what happens is: 1. If user expands artist A in node 'Artist & Album Artist', album L is shown in the tree. It isn't clear whether it is correct, but I'd say that it is, because user can easily see all the albums artist is involved in. 2. If user expands artist A in node 'Album Artist', album L is also shown in the tree. It seems to be incorrect (and was reported as a bug by a user), because artist A isn't Album Artist of the track. 3. In 'Artist' node, album L is also shown, which is probably correct, but it's hard to decide whether to show also albums, where A is album artist. We probably shouldn't show them, but then it would be a little strange to show albums, where A actually is only as an involved artist. Maybe we could eliminate showing of child album nodes in 'Artist' node altogether? | ||||
| Additional Information | http://www.mediamonkey.com/forum/viewtopic.php?t=20620 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1086 | ||||
| related to | 0003617 | closed | petr | Regression: Genre node subnodes include tracks that don't match the Genre |
| related to | 0003443 | resolved | petr | Album Artist node: Album Artist subnodes aren't shown if Album title is unknown |
| related to | 0003560 | resolved | petr | Album Artist Node: It should be possible to Drag and Drop Albums between Album Artists |
| related to | 0003718 | closed | rusty | Scanning problem of multiple artists albums? |
|
|
Assigning to Rusty to review. |
|
|
Tested 1082 and I agree that there are some regressions in functionality: 1. Historically we never displayed Album L sub to <Artist> in the Artists & Album artists node since to do so would make drag and drop within this node meaningless. i.e. now it's clear that d&d of the Album from AA1 to AA2 will change the Album Artist. 2. Agreed. Case Gii) below. 3. I think that the current implementation is fine. It just shows Tracks organized by contributing Artist--not sure why this would be confusing (users expect child nodes to be a subset of the parent node). Upon testing this functionality further, I found a few similar related problems (see below). Almost all problems relate to how tracks are handled when Artist|=Album Artist. Album Artist/Artist node ======================== a) Node Tracklist. OK (All tracks are listed sorted by Artist). b) Selecting an Artist=Album Artist i) >Artist. OK. Artists nodes appear as expected. Tracklist contains all tracks by Artist. ii) >Artist>Album. OK. All albums appear. Tracklist contains tracks per album. c) Selecting an Artist|=Album Artist i) >Artist. OK. Artist node appears as expected. Tracklist contains all tracks by Artist or Album Artist. ii) >Artist>Album. FAIL. Album node appears as expected, however, the Tracklist contains all tracks on the album rather than just the subset by the Artist. e.g. . . Album Artist>The Shins>Garden State contains . . Caring is Creepy by the Shins . . In the Waiting Line by Zero 7 . . Fair by Remy Zero d) Selecting an Album Artist|=Artist i) >Album Artist. OK for cases where Album Artist=Various--node appears and tracks where Album Artist=various are listed. But it FAILs in another case: I have an Album by Sting as follows that for some reason is listed under Various. The Album is: Forget About the Future, Artist=Sting, Album Artist=Sting Inside, A=Sting, AA=Sting Rise and Fall, A=Craig David, AA=Sting The tracks listed under 'Various' are: Forget About the Future, Sting, AA=Sting Inside, Sting, AA=Sting I have no idea why any tracks from this album are listed under Artist & Album Artist > Various!! Additional tests (build 1085): Clean scan: This isn't replicable Upgrade from 2.5: Not replicable ii) >Album Artist>Album. FAIL. ---- 1) In some cases Album nodes appear correctly, however, the tracklist doesn't always show the correct content. e.g.: For the Sting Album Above, track by Craig David does not appear in the tracklist Artist & Album Artist > Sting > Sacred Heart Additional Tests (build 1085) Clean scan: This bug doesn't occur Upgrade from 2.5: Not replicable ---- 2) For Artist & Album Artist > Various, no Album nodes appear! Additional Tests (build 1085) Clean scan: This bug persists Upgrade from 2.5: not replicable Album Artist node ================= e) Selecting Album Artist=Artist i) >Album Artist. OK. ii) >Album Artist > Album. OK. f) Selecting Album Artist|=Artist i) >Album Artist. FAIL. Works in most cases e.g. Album Artist=The Shins lists all tracks by Album Artist=The Shins, but fails in the example given in di) in exactly the same manner as di). ii) >Album Artist > Album. FAILs in the same manner as dii), and additionally, all tracks Where Artist=Sting do not appear in Album Artist>Sting even though Album Artist=Sting!! g) Selecting Artist|=Album Artist i) >Album Artist. OK -- Artists don't appear. ii) >Album Artist > Album. Failed--in cases where an Album Artist appears legitimately, it will contain albums in which the Album Artist is a contributing Artist--even albums for which the Artist isn't the Album Artist. e.g. Album Artist=The Shins will include the Garden State soundtrack as a node even though The Shins isn't an Album Artist for that album. Artist node =========== h) Selecting Album Artist=Artist i) >Artist. OK. ii) >Artist > Album. OK. i) Selecting Artist|=Album Artist i) >Artist. OK. ii) >Artist > Album. OK. j) Selecting Album Artist |= Artist i) > Album Artist. OK. Doesn't appear. ii) > Album Artist > Album. OK. Doesn't appear. |
|
|
gii) Should be fixed. cii) I'm not sure, I prefer to see full albums, even though they don't fully belong to the active filter/node. We might fix it, but I don't see it as too urgent. di) and other are described in 0003718, they are probably part of another issue. |
|
|
notes with build 1085: cii) I disagree re. priority. This should should be implemented in a manner similar to how the rest of MM works--subnodes should contain a subset of parent nodes (discussed in the forum with respect to a similar bug for Genres 0003617). Also, I suspect that D)ii)2) may be part of this bug (i.e. not a scanning bug), but I'm not certain. |
|
|
Confirming that d)ii)2) is a bug - it happens in AddArtistAlbums() because ArtistsSongs is used there instead of ArtistsAlbums. I haven't fixed myself yet because it has to be reviewed which functions to use for Artist and which for Album Artists. |
|
|
OK, so to summarize, the only reproducible bugs are: c)ii), g)ii), d)ii)2). The other issues from d) and f) will be tracked at 3718, however, at the moment, they aren't reproducible. |
|
|
Implemenatation clarification: c)ii) Album Artist/Artist node: Album subnode shouldn't contain tracks where the selected artist is neither Artist, not Album Artist. d)ii)2) Album Artist/Artist node: Should be listed albums where the selected artist is either Artist (contributing) or Album Artist (currently only Artist is used). g)ii) This is actually the same as c)ii), just in Album Artist node in this case. |
|
|
I think that Jiri's comments aren't what I'd intended: c)ii) Elaboration: Album Artist/Artist node: Album subnode shouldn't contain tracks where the selected artist is neither Artist nor Album Artist (i.e. the album subnodes should only contain tracks for which the selected Artist is either the Album Artist or Artist). d)ii)2) Correction: Album Artist/Artist node: Should list album nodes where the selected artist is Album Artist (currently only Artist is used). g)ii) Correction: This is actually a bit different than cii). cii) is a problem about the tracks that are contained within the selected Artists' subnodes, whereas this bug is about the subnodes that are contained within the selected Artist node. In this bug, the Album Artist node contains incorrect subnodes--it contains Albums in which the Album Artist is a contributing Artist --even albums for which the Artist isn't the Album Artist (whereas in cii (Artist/Album Artist node) this is acceptable). To resolve, we just need to ensure that the selected Artist in the Album Artist node only contains Albums for which the selected Artist is the Album Artist. |
|
|
Fixed items c)ii), d)ii)2) and g)ii). Will be in 1086. |
|
|
Verified 1088. |
