View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003686 | MMW v4 | Playlist / Search | public | 2007-09-30 10:12 | 2007-10-13 23:59 |
| Reporter | Assigned To | ||||
| Priority | immediate | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.0 | ||||
| Fixed in Version | 3.0 | ||||
| Summary | 0003686: Regression: Search doesn't work with logical operators (' '=AND, ""=exact, ';'=OR) | ||||
| Description | "search in current node" no longer works with new logical operators (' '=AND, ""=exact, ';'=OR) it works just like it did in 2.5, however, search in filtered library and whole library works correctly. Dale. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1084 | ||||
|
|
by the way.. I'm using build 1081 |
|
|
It is not a regression. It never worked that way for searching of curent selection. As you are writing it only works for searching in filtered library and whole library. And I think that it works fine now, because: When you are searching whole lib, it is more like google searching for a web page and this operators are helpful, but if you are searching for an exact phrase in current selection it is more like searching an exact text on a web page and therefore this operators should not be applicated. Assigned to Rusty for review. |
|
|
I have to disagree strongly. Searching through text on a web page is like the search in the now playing, which yes, should search in the way that you mention. However, searching in the current node is just like searching in the whole library, just with a smaller subset. If the user wants to search an exact phrase then they can do so by "wrapping it in quotes" - which they will be used to from the normal search - why confuse them by making it work differently. Search in current node will also often be applied to the whole library anyway as many people will use it while on the root artist node or the like (and on the main library node when it actually starts populating). Dale. |
|
|
I agree with both of you. Search current selection should work the way Dale describes for all but the NP node. |
|
|
I've changed the bug description slightly to make it more general (i.e. it applies to search selected and search entire library. It seams that search in General is a bit broken in 1081. e.g. Search for the cure and a bunch of unrelated entries appear even when 'Search Entire Library' is enabled. reported at: http://www.mediamonkey.com/forum/viewtopic.php?t=21270 |
|
|
Rusty I don't understand what is wrong with this. If you search for: The cure ...yes, it results everything where the word "the" and the word "cure" is included, i.e. ' '=AND operator. and if you search for "the cure" (quoted) then it results everything including the exact phrase "the cure". So what is wrong with 'Entire Library' searching? |
|
|
Ludek, this is very strange. On my machine it returns a whole bunch of tracks, many of which do not have 'cure' anywhere within!! I tried this again on build 1082, and experienced the problem! |
|
|
This is caused by searching EncodedBy field - which is in DB, but isn't anywhere in MM UI yet. We should remove it from searched fields, as well as other fields that aren't visible anywhere in MM (e.g. all 'Web...' fields. |
|
|
Ok, I removed EncodedBy, Band, Remixer, InitialKey, Language, RatingString, WebCommercial, WebCopyright, WebFilepage, WebArtist, WebSource, WebRadio, WebPayment, WebPublisher, WebUser in build 1083. Because these should be definitevly removed - they are not visibled anywhere. But I think about removing also some visibled fields like comment, lyrics (word like 'obscured' contains 'cure') and maybe all fields presented on the 'Details' page at Track properties dialog. Assigning to Rusty to consider whether these should be removed from library searching too. |
|
|
If we're hardcoding this, then the only items i'd remove are the read-only items in the lower half of the details page. (length, bitrate, frequency, counter, etc.). I think that it's possible that users will want to quicksearch lyrics and/or comments. |
|
|
ok, it is. i.e. length, bitrate, frequency, counter are not searched now. |
|
|
Fixed also the original problem: "Current selection" search doesn't work with logical operators (' '=AND, ""=exact, ';'=OR) in build 1084. |
|
|
Verified 1087. |
