View Issue Details

IDProjectCategoryView StatusLast Update
0004035MMW v4Properties/Auto-Toolspublic2007-12-10 01:53
ReporterLudek Assigned To 
PriorityimmediateSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version3.0 
Fixed in Version3.0 
Summary0004035: Regression: toolbar buttons like <artist> is missing from destination wizard
DescriptionAs reported here:
http://www.mediamonkey.com/forum/viewtopic.php?t=22332
the user is missing the one click <buttons> for constructing a mask.
We eliminated it from various portions of UI, but I don't undertand why we eliminated it from Destination Wizard (launched via [Configure] button)?

I think that the buttons are needed on the wizard, because there is no other way (except typing) to set mask like <artist> on the wizard!
TagsNo tags attached.
Fixed in build1115

Relationships

related to 0002370 closedpetr Rationalize Masks implementations across the product 
related to 0004113 closed Mask Configuration: '>>' button should toggle mask list on/off 

Activities

Ludek

2007-11-27 10:57

developer   ~0012196

Assigned to Rusty for review, warrant and prioritizing.

rusty

2007-11-27 14:29

administrator   ~0012199

Yes, that's definitely a mistake. There should be a dropdown button next to each of the 2 masks in the set destination dialog.

Ludek

2007-11-28 14:43

developer   ~0012211

Last edited: 2007-11-28 15:06

Upon discussion with Petr the mask buttons were removed in 1089 and verified by Rusty. i.e. This suggestion contradict with that.

Assigning to Rusty for making a decission again (because of this contradiction)

I think that we should add the toolbar buttons (<Artist><Album><Title>) again so that the needs of users like kknostman ( http://www.mediamonkey.com/forum/viewtopic.php?t=22332 ) would be satisfied and in addition the buttons will not take a necessary room in the wizard.
i.e. I mean that we should add it only to the 'Set Destination Wizard'

Note: As Petr wrote me the buttons was probably removed because of some skin issues (they appeared with black text / font), but I found out that the problem was in using a bad visual component for this (TBItem instead of TBXItem) and this was the reason for the black text although the text should be white!
By using the right component (TBXItem) the text is white (depends on skin).

rusty

2007-11-28 16:03

administrator   ~0012213

Thanks for correcting me. I completely misunderstood the issue.

The problem that kknostman raises can be divided into 2 issues, both of which we already know about but have previously pushed off:

1) The '>>' dropdown list in the advanced panel should remain open until the user closes it. That way the user doesn't have to click it each time. Fixing this would probably fix most of kknostman's problem.

2) The 'Configure' button was a compromise that didn't turn out so well. The preferred implementation would have been to have an Advanced>> button that would change the mode of operation of the dialog. Because of time considerations, we ended up with an implementation that presents an Advanced configuration mode initially, but doesn't clearly communicate the fact that two modes of operation exist. The best short-term fix might be to change 'Config' to 'Wizard' in 3.02.

Ludek

2007-11-28 18:53

developer   ~0012216

O.k. Assigning to Petr to make the short-term fix and to implement what you mentioned in 12199 note:

3) There should be a dropdown button next to each of the 2 masks in the set destination dialog

and finally:

4) The 'Configure' button is missing from 'Autotag from Filename' (it should be there next to the [>>] button like on all the others dialogs, isn't it?)

rusty

2007-11-28 19:11

administrator   ~0012217

2) To clarify: I mean that only this particular item should be deferred beyond the current release since it would involve a fair number of changes and/or new localization strings.

3) I suppose that we could add the '>>' button, however, we'd have to be careful about how this is implemented since clicking the Combo box in the 'Set Destination Wizard' causes plain text representations of the mask to appear.

4) The current design of the dialog doen't make sense for auto-tag (i.e. the dialog is designed to show how a mask maps to a directory/filename but not the other way around). Do you disagree?

Ludek

2007-11-28 19:32

developer   ~0012218

Yes, you are right that 4) doesn't make sense.

petr

2007-11-29 15:04

developer   ~0012229

I've added '>>' button as described as item 3. Will be in 1110.

rusty

2007-12-09 15:51

administrator   ~0012421

Tested 1115 and:
5) The mask button and masks are listed, however, they are different in order/groupings than in the Main Auto-organize panel. i.e. what should appear is something similar to what appears in auto-organize (it could be identical, or perhaps just include the descriptions without the actual masks).

1) Is it not possible to make it work in a manner such that the user can go back and forth between the Mask list and the mask without having to continually press '>>'? If it's too risky we'll defer.

petr

2007-12-09 18:03

developer   ~0012426

Item 5 fixed.
Item 1 is a bit difficult so i think we'll defer it.

rusty

2007-12-10 01:53

administrator   ~0012441

Verified 1115.