View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004234 | MMW v4 | Properties/Auto-Tools | public | 2007-12-30 22:57 | 2013-12-10 00:26 |
| Reporter | peke | Assigned To | |||
| Priority | urgent | Severity | crash | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 3.0 | ||||
| Summary | 0004234: AutoDJ Functionality Issues | ||||
| Description | While making Functional ScrobblerDJ I have found that AutoDJ have several Issues 1. Info PopUp is Delayed until AutoDJ Finishes 2. Player is Locked until AutoDJ Finishes 3. Embed Do not work In several cases. 4. MM Freezes all its functions Completely untill AutoDJ Finishes and if there is error in Script you can't close MM or Change track (End task is needed) 5. There are few regarding Speed, calculation of what is played and what is not played, Shuffle Next/Prev Option. 6. Executed Multiple Times instead of Just Number of Needed Times especially When AutoDJ Should Maintain at least 2+ Tracks When 1 all is working OK | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1128 | ||||
|
|
1 InfoPopUp init moved Before AutoDJ Check 2 Creating Self Maintaining Thread That will Free memory to avoid Mem Leaks and free MM (This should also improve 4) 6 is fixed but it introduce Regression which result AutoDJ is not Triggered when needed in some cases. SVN Is not updated due to possible regressions rising and until found regressions are solved |
|
|
3. Confirmed by Petr. |
|
|
5. If you have large NowPlaying 3000+ Tracks AutoDj Is Slow. As it checks each played status in Shuffle mode on all tracks. |
|
|
I've reviewed / fixed it. So in summary 2. and 3. are regressions and were caused by Petr in revision 4553 - FullPlayer.pas (Auto-DJ should not be synced with main thread in case of embed) Fixed in 1128. 1. Fixed in 1128. 4. Fixed in 1128. Re: 5. I'm not sure it could be improved somehow, but it is not an issue now (running on separated thread) Re: 6. Seems to be needed in some special cases (e.g. we don't want to add dead links to now playing list - so we need to mine more songs and the routine is called again), but this also should not be an issue now (running in separated thread) Now, all is safely fixed and works nice (smoothly). |
|
|
1,2,3 Confirmed Fix 4 Have tested but will do more tests with some other "bad" Scripting examples 5 Agreed, will test how we can speed things by making use of code in LastFM plugin and then will open new Bug if needed 6 Agreed, will do more extended tests with ScrobblerDJ and see if there is regressions and possible way to speed process when executing AutoDJ Scripts I'll reopen if needed but 1,2,3,4 works Smooth and Safe like you pointed. |
|
|
Reverted item 4 because of a high risk of regression (after testing with some scripts I found a possible EOleExceptions and drawing canvas outside of main thread exceptions) |
|
|
Assigning to me till all issues located. |
