View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004956 | MMW v4 | Now Playing | public | 2008-11-23 21:01 | 2008-12-01 14:21 |
| Reporter | peke | Assigned To | |||
| Priority | high | Severity | tweak | Reproducibility | always |
| Status | resolved | Resolution | no change required | ||
| Summary | 0004956: If Enabled AutoDJ should be also called on TrackEnd event | ||||
| Description | In Case that AutoDJ is Enabled and User deletes all tracks while track is playing, making that Current Track is Last track on NP. AutoDJ should be Executed on TrackEnd only in case that IncreasePlayCounter procedure is executed under procedure TFullPlayer._OnTrackEnd as in any other case Playback will stop and user interaction will be needed or in case of Repeat enabled NP would be restarted from beginning which will also in some cases result in stop of playback. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | |||||
|
|
It should be easy to implement from procedure TFullPlayer._PlayThread |
|
|
Peke, is there any other case except when User deletes all tracks while track is playing? If not then I would rather launch AutoDJ immediatelly after clearing NP, because auto-dj is intended running on own thread so that it doesn't cause gaps between tracks. But I am not sure that it is user desired, I think that if anyone clear NP then he want have NP clear and he don't want auto-dj to add another track. |
|
|
I'm not sure that it is good idea to run it as soon as NP is cleared due the fact that user maybe wants to add several tracks manually as tracks picked by AutoDJ not satisfy user. There is lots of time to add tracks while track is playing. Option that I propose will activate AutoDJ only in case if MM will stop playback unless AutoDJ adds some tracks. |
|
|
And user do not need to delete all tracks from NP just tracks below Currently Playing track which will leave currently playing track last track on playlist. |
|
|
It seems to me to be ok to Stop playback after user cleans Now Playing completely. Then after Play button is pressed, Auto-DJ can normally add some tracks to NP and continue as usually. Feel free to close the issue if you agree. |
|
|
You are right it is logical to act like that I never thought from that perspective. |
