View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005265 | Last.fm plugin | Last.fm | public | 2009-01-30 06:56 | 2009-11-16 21:33 |
| Reporter | rusty | Assigned To | |||
| Priority | immediate | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Summary | 0005265: Last.fm Scrobbler: exclusion list | ||||
| Description | Users should be able to select which tracks are/aren't submitted via the scrobbler. Possible UI: [x] Exclude tracks that aren't in the library [ ] Exclude tracks from the following playlist: ______________ | ||||
| Tags | No tags attached. | ||||
| Fixed in build | |||||
|
|
I'd like to see ability to ignore or exclude certain Filters for scrobbling (i.e. exclude Podcasts from scrobbling). |
|
|
Is it better/clear to use: [ ] Exclude tracks not in filter: ______________ instead of [ ] Exclude tracks from the following playlist: ______________ As that will give users GUI to clearly classify Submit filtering rules Possible Final UI: --- Filtering --------------------------------------------- |[x] Apply filtering rules for sending Nowplaying |[x] Exclude tracks that aren't in the library |[x] Force Active Filter (if available) |... [ ] Exclude tracks in following filter: ______________ --------------------------------------------------------- Notes: 1. Filtering priorities are enforced in that order where Exclude will override submitting the track even it pass active filter rules. Examples when Exclude Tracks is selected: 1. Is track filtered by active filter = True -> is track in Filter "Audiobooks" = True -> Do not submit track 2. Is track filtered by active filter "General Music" = True -> is track in Filter "Audiobooks" = False -> Submit track 3. Is track filtered by active filter "None (Show All Tracks)" = True (No Active Filter Available) -> is track in Filter "Audiobooks" = True -> Do not submit track 4. Is track filtered by active filter "None (Show All Tracks)" = True (No Active Filter Available) -> is track in Filter "Audiobooks" = False -> Submit track |
|
|
Personally I'd prefer exclude tracks not in filter, but hard to say what most users would prefer. I'd think that excluding by filter is more intuitive and clear than selecting just a single playlist to exclude. |
|
|
I agree that exclusion by filter makes more sense. The reason I suggested playlists initially is so that non-Gold users would be able to use the functionality. Perhaps a hybrid approach where the user can select to use filters or playlists would be best. e.g. [x] Exclude tracks that aren't in the library [ ] Exclude tracks from the following [Filters/Playlists]: [ ] Filter 1 [ ] Filter 2 ... [ ] Don't show Now Playing tracks that are excluded to my Friends on Last.fm. In terms of some of the other options that you'd suggested: - Apply filtering rules for sending now playing. Is that option really necessary? i.e. if the user doesn't want to publicise tracks that match the filter, then why would they want to show them as playing? Btw, if you think we still need this, the language suggested above would be better. - Force active filter (if available): what does this mean? |
|
|
1. Problem with playlists is that they can be slow especially if they are Auto-Playlists and user have large library, also filter can be selected even in non gold but no new can be added and "General Music" Filter is added by default which is reason why I made not in Filter as selecting "General Music" will exclude Podcasts, Audiobooks. Now as I look a this like you two said and assume that it is excluded by filter. Non-gold users do not have default Filter setting to filter "Podcasts & Audiobooks" together but only each one separately which will make your proposal Exclusion by Filter possible. Maybe this is for new bug? 2. I do not see the reason for Multiple filters which will make things much slower? BTW that is why I added Force Active Filter where if User have selected Active Library filter "General Music" only tracks that are in "General Music" Filter will be considered to be scrobbled unless they are like you proposed in Selected filter 3. Regarding Now Playing I agree as maybe it is not needed at all, I'm also thinking to remove Now playing Scrobbling UI option from "Last.fm Services", but leave INI setting if users want to enforce no Now Playing scrobbling at all. Toolbar button made that obsolete? |
|
|
UI proposal that can be on Single sheet: ------------------------------------------------------------------------------- Last.fm can automatically help you find people that have similar musical tastes and creates personalized music recommendations. To learn more visit www.last.fm --- Last.fm Service ------------------------------------------------------------ [x] Submit played tracks to build my Last.fm profile and get music recommendations ....[ ] Only submit tracks if Album metadata exists [x] Exclude tracks that aren't in the library [x] Scrobble tracks in Active Filter [x] Exclude tracks from following Filter: [Podcasts & AudioBooks[\/]] ------------------------------------------------------------------------------- [x] Show Toolbar icon --- Log File (Last 5 Entries) ------------------------------------------[Refresh]- .... .... .... .... .... ---[Show Log File]-----------------------------------------------[Clean cache]- ------------------------------------------------------------------------------- |
|
|
1. Users will want to exclude: -Podcasts -Audiobooks -Childrens Music -Other spoken word content (e.g. Comedy) -Foreign language music -Unrated / unclassified music From my perspective, the first four are filters and the last two would be playlists, accounting for why I thought both are required. On the other hand, if you think that this is too difficult from an implementation perspective, then the only realistic approach would be for the user to create a single playlist that matches any of the above criteria (I don't think that it would make sense to create a Filter that matches the above). 2. I'm not sure about the 'Scrobble tracks in active filter' option. I think it's simpler to just have an exclusion list instead of an inclusion list and an exclusion list. 3. I would propose to keep the now playing option exactly as it is today, only submitting tracks that aren't on the exclusion list. Once we agree on these items, we can get into the UI details. |
|
|
1. Following your proposal I've created one Filter and one Auto-Playlist with same criteria (Screenshot of Both settings are uploaded to FTP) and have done Speed test on both of them to compare speed on my 120k Library. the results are that Auto-Playlist needed 2.457 Sec to refresh query. where filter has done in 0.127 Sec. After IM talk with Petr even they both use same query (when same parameters are used), filter's are using that query prepared (internally) which is faster. 2. I thought that it would give users additional way to control Scrobbling as we say that filtering is almost like using two libraries. But you are right that having both inclusion and exclusion can confuse users. Here is an example, I use my own MM library filter and each of my family member use their own Filters when using MediaMonkey but we all do not want to scrobble "Podcasts and AudioBooks" along with tracks that I listen which are not on theirs filters. Initially when they use/start MediaMonkey they firstly set their filter active and then they listen/scrobble tracks, so only tracks that are in their Active filter should be Scrobbled without worry that if they listen to track that is filtered will temper with their last.fm statistics. 3. Now playing functionality will be same as now only UI option could be removed due the fact that it only handles last.fm Now Playing functionality will be activated or not see big berny note http://www.ventismedia.com/mantis/view.php?id=5190#c16526 and there will be always INI setting in case that Users do not wish that now playing is sent in real time. |
|
|
1. OK, so let's use filters to begin with. But you'll probably need a means of allowing the user to exclude multiple filters (filters can't be nested). 2. I still don't understand how 'Scrobble Tracks in Active Filter' helps. i.e. if the goal is to limit scrobbling to music 'belonging' to the user whose credentials are filled in the Last.fm config panel, then the panel should have the ability to let the user configure which music belongs to the user. i.e. 'Only scrobble music matching the following filters:'. Scrobbling tracks based on which filter is active wouldn't meet your objective! 3. Isn't the point of Bernie's note that 'Show Now Playing Tracks to my Friends on last.fm' shows tracks even when caching is enabled, and he thought it shouldn't? I.e. he's not arguing to eliminate the UI, but rather to automatically disable this function if caching is enabled. |
|
|
1. That can be done easily as Option Sheet Already reads List of Filters. Multi Checkbox can be used. Only issue with that is Space on Sheet. Should We make that in Sub-Sheet of last.fm Service? 2. If using multiple check criteria than you are right that there is no need for this, my original intention was that plugin scrobble only tracks that are in library using current filter and have second criteria that will exclude tracks in selected filter, but the more I think about I agree with you that it adds additional confusion. 3. Yes, now playing is not sent when caching only is enabled as of v1.0.2.18, so that option only affects if Now playing will be sent at all or not. Most of users want to send now playing if they scrobble (enabled by default) and when they Disable Plugin they want to disable Now Playing also, same with cache only. Leaving INI possibility we will only keep this functionality "Scrobble plays to last.fm but do not send now playing info". I proposed that for getting needed UI space for filtering options and if we decide to create sub sheet (needed for multi filter selections) there is no need to remove that option especially as it's localized. |
|
|
1. It's preferable to fit it on the same panel, but if it's not possible... 3. OK, though: --the new behavior must be as you wrote: if the scrobbler is enabled, then NP option is enabled; and if the scrobbler is disabled, then NP option is disabled EXCEPT if the user specifically configures the INI option to always disable/enable NP. --you might want to ask users if any of them care about this feature before moving it to the .ini file. |
|
|
Suggested in offline discussion: [ ] Submit played track to build my Last.fm profile and get music recomendations [x] Show Now Playing tracks to my friends on www.last.fm [Submission rules] . . . If the user clicks the Submission rules button --> ------------------------------------------------------ Submission Rules ------------------------------------------------------ [x] Only submit tracks if Album metadata exists [ ] Only submit tracks that are part of the Library Exclude tracks that match the following filters: ---------------------------------------------------- | [ ] Podcasts | [ ] Audiobooks | . | . | . ---------------------------------------------------- |
|
|
added in v1.0.2.19 |
|
|
Tested 1.0.2.20 and the exclusion list is working for items that are preselected (i.e. Podcasts and Audiobooks). However, when I select any other filters that I've created, tracks that are played that match those filters aren't excluded. In addition to the above, but possibly a cause of the above, when some filters on the exclusion list are checked off, the setting doesn't persist. i.e. Tools > Options > Last FM > Submission Rules > check off 'Test filter' and click OK 2x. Close MM & restart --> the setting doesn't persist. This issue occurs for filters that need to be scrolled to to be checked/unchecked. |
|
|
Fixed in 1.0.2.21 |
|
|
Verified in 1.0.2.21. Created new Exclude from Last.FM filter to exclude all podcasts except music podcasts (Album not = <list>). Only problem was that I had to restart MM after install to get the function to work properly. |
|
|
I had the same problem as Owyn, it would also be nice if the filters could be sorted by either their name or their position, the ID is not an ideal sorting tool. |
|
|
Exclude filter not used if "Only submit tracks if album meta-data exists" unchecked. |
|
|
Exclusion is inconsistent. I noticed that some excluded episodes are NOT caught in the filter even though they do show in the songs list if I make the exclusion filter active. Can not get a reproducible test case to cause failure. Thought it might be related to whether the exclusion filter was the active filter. Most times it works, sometimes it won't. |
|
|
Now have reproducible case. 1) Let MM3 come to idle. Nothing played. Nothing in Now Playing. 2) Loaded 4 podcast episodes to Now Playing. The 1,2 and 4th are in my Exclude from Last.Fm filter (filter 7). The 3rd is not (removed by artist contains test). C:\Data\Podcasts31\APM- Garrison Keillor's The Writer's Almanac Podcast feed\Jul. 13, 2009- The Writer's Almanac.mp3 C:\Data\Podcasts31\NPR- Story of the Day Podcast\Birds' Survival Relies On World's Largest Crab Orgy.mp3 C:\Data\Podcasts31\Today In Music History\Today in Music History- July 13, 2009.mp3 C:\Data\Podcasts31\NPR- World Story of the Day Podcast\Different Rules Strain Ties With China's Minorities.mp3 3) Used Play Now on 1st track. Monitored Last.FM web status and log during test. Only the 3rd track ever shows as "Listening Now" on the web, however, all of them eventually show as Listened. Noticed that the log shows submit of filtered tracks. Log follows. 13/07/2009 11:00:23.679: Last.FM: Nowplaying Play Detected at 1247497223 13/07/2009 11:00:23.730: Last.FM: Session ID d6c187d6a92841a6bd2d35523c129104 13/07/2009 11:00:24.204: Last.FM: NowPlaying Skipping as Track is excluded by FilterID 7 13/07/2009 11:05:39.055: Last.FM: Submit Started at 1247497539 13/07/2009 11:05:39.059: Last.FM: Session ID d6c187d6a92841a6bd2d35523c129104 13/07/2009 11:05:39.106: Last.FM: Nowplaying Play Detected at 1247497539 13/07/2009 11:05:39.356: Last.FM: Submit American Public Media - Jul. 13, 2009: The Writer's Almanac 13/07/2009 11:05:39.433: Last.FM: Submit Started 13/07/2009 11:05:40.057: Last.FM: Submit OK 13/07/2009 11:05:40.071: Last.FM: Session ID d6c187d6a92841a6bd2d35523c129104 13/07/2009 11:05:40.255: Last.FM: NowPlaying Skipping as Track is excluded by FilterID 7 13/07/2009 11:13:18.982: Last.FM: Submit Started at 1247497999 13/07/2009 11:13:18.985: Last.FM: Session ID d6c187d6a92841a6bd2d35523c129104 13/07/2009 11:13:19.033: Last.FM: Nowplaying Play Detected at 1247497999 13/07/2009 11:13:19.463: Last.FM: Submit NPR - Birds' Survival Relies On World's Largest Crab Orgy 13/07/2009 11:13:19.504: Last.FM: Submit Started 13/07/2009 11:13:19.873: Last.FM: Submit OK 13/07/2009 11:13:19.951: Last.FM: Session ID d6c187d6a92841a6bd2d35523c129104 13/07/2009 11:13:20.180: Last.FM: NowPlaying Started 13/07/2009 11:13:20.199: Last.FM: NowPlaying Brian Ibbott - Today in Music History: July 13, 2009 13/07/2009 11:13:20.502: Last.FM: NowPlaying OK 13/07/2009 11:17:34.633: Last.FM: Submit Started at 1247498255 13/07/2009 11:17:34.637: Last.FM: Session ID d6c187d6a92841a6bd2d35523c129104 13/07/2009 11:17:34.685: Last.FM: Nowplaying Play Detected at 1247498254 13/07/2009 11:17:35.123: Last.FM: Submit Brian Ibbott - Today in Music History: July 13, 2009 13/07/2009 11:17:35.206: Last.FM: Submit Started 13/07/2009 11:17:35.596: Last.FM: Submit OK 13/07/2009 11:17:35.915: Last.FM: Session ID d6c187d6a92841a6bd2d35523c129104 13/07/2009 11:17:36.632: Last.FM: NowPlaying Skipping as Track is excluded by FilterID 7 13/07/2009 11:22:05.759: Last.FM: Submit Started at 1247498526 13/07/2009 11:22:05.763: Last.FM: Session ID d6c187d6a92841a6bd2d35523c129104 13/07/2009 11:22:05.984: Last.FM: Submit NPR - Different Rules Strain Ties With China's Minorities 13/07/2009 11:22:05.993: Last.FM: Submit Started 13/07/2009 11:22:06.318: Last.FM: Submit OK |
|
|
This feature fails for me reliably, my only rule is to exclude the 'Podcasts' filter, yet my podcast plays are still submitted to last.fm. |
|
|
I do not know if it was the installation of 1267 or one of the prior recent beta releases but the installation cause the selection of my filter settings to be removed, so this was failing for me also. But once I reestablished the filter, the rule is working as it should. But, I am not sure if the installation knocked out the rule or if a restore from a backup did... |
|
|
Last.Fm has major maintenance scheduled for this weekend. Just checked and still getting database busy on cache submits. Will retest tomorrow with 1267. |
|
|
1267 leaves problem unchanged. Retested using filter 1 (Podcasts). Excluded tracks are NOT shown as now playing on Last.FM web interface, but, are later submitted and shown as just played. See prior log for examples. |
|
|
Fixed in 1.0.2.22 Note: Fixed invalid Filters index check on Submit |
|
|
Users Verified fix in 1.0.2.22 Release NOTE: 0005265 Fixed wrong exclusion indexing on Submission check to last.fm Steps to Test Regressions: 1. Open Submission rules 2. Select only Podcast filter 3. Play podcast You will notice that now playing will be filtered correctly, but track will be submitted even it should be excluded. |
