View Issue Details

IDProjectCategoryView StatusLast Update
0005326MMW v4Playlist / Searchpublic2009-04-03 22:54
Reporterstephen_plattAssigned To 
PriorityimmediateSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version3.1 
Fixed in Version3.1 
Summary0005326: Boolean "OR" doesn't work correctly in some cases
DescriptionFor example,

'played: 0 AND rating: 4..' :75 tracks match (this is right)
'played: 0 OR rating: 4..' :no result

'length: 600.. AND bitrate: 128..' :180 tracks match (this is right)
'length: 600.. OR bitrate: 128..' :5 tracks match
Additional Informationhttp://www.mediamonkey.com/forum/viewtopic.php?f=6&t=37417
TagsNo tags attached.
Fixed in build1227

Relationships

parent of 0005370 closedLudek Boolean Search: Add support for 'AND' (in addition to space) 
related to 0009195 closedLudek Search including OR throws SQL error in Quick Search 

Activities

Ludek

2009-02-23 14:57

developer   ~0016927

Fixed in build 1225.

stephen_platt

2009-03-05 01:17

developer   ~0016990

verified 1225

Ludek

2009-03-05 13:22

developer   ~0017006

Re-opened, because there are still some issues, see:
http://www.mediamonkey.com/forum/viewtopic.php?f=6&t=37417

'rating: 4.. OR grouping:test' :match 0 files
'grouping:test OR rating: 4..' :match 248 files

Fixed in 1226.

rusty

2009-03-10 16:57

administrator   ~0017035

Tested 1226.

rating:4 AND genre:test doesn't correctly AND the 2 criteria.
genre:test AND rating:4 does.

Not sure if this is a regression related to the above.

jiri

2009-03-10 17:25

administrator   ~0017036

The current code in SVN seems to have even a little more mixed results:

genre:rock rating:4 // Seems to be correct
genre:rock AND rating:4 // WRONG - 0 results
genre:rock OR rating:4 // Seems to be correct
rating:4 genre:rock // WRONG - many results, seems to work as if there is OR operator?
rating:4 OR genre:rock // Seems to be correct
rating:4 AND genre:rock // WRONG - not sure how wrong, doesn't seem to be OR, rather some subset of 'rating:4 OR genre:rock'

As discussed over IM, we also need to slightly improve design of the currently implemented automated regression testing.

Ludek

2009-03-10 21:16

developer   ~0017046

Last edited: 2009-03-11 08:07

Note that AND is not an acceptable boolean operator, we have never added it in addition to OR, we only added NOT as I remember (issue 0005280). Therefore AND is represent as word 'and' that needs to be included in the search results.

Nevertheless I opened 0005370 as child issue in order to add support for AND operator.

So the only problem here is:
rating:4 genre:rock // WRONG - many results, seems to work as if there is OR operator?
- this is really regression and is fixed in build 1227. I improved regression testing and covered this test cases by automated regression testing.

stephen_platt

2009-04-03 22:54

developer   ~0017346

verified 1232