View Issue Details

IDProjectCategoryView StatusLast Update
0006598MMW v4Skinspublic2010-12-06 02:28
Reporterrusty Assigned To 
PriorityimmediateSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version4.0 
Target Version4.0 
Summary0006598: Tweaks to Vitreous skin
DescriptionLatest version of vitreous is looking fantastic. I'd suggest just a few changes:

1) When the 'Track Browser' (soon to be renamed 'Column Browser') is active, there's no clear border between it and the track list, and the left border of the tracklist seems to stop at the junction of the 'Track Browser'. Can this be resolved? Do you need changes from Petr to resolve this?

2) Player: The seek bar isn't centred. How about adding rating configuration to the immediate right of the seek bar to balance things out? Might also be worthwhile to add a scrobbler button (I'm not sure if the functionality is yet integrated).

3) There are 2 'collapse' buttons right now:
i) Collopse 'Entire Library' (appears immediately to the right of the back/forward buttons
ii) Collapse all nodes to root (it's the 'speaker' button)
I would suggest that the two icons should be somewhat similar (note: I'm thinking that we'll remove the 'Collapse to Entire Library' button in the default config).

4) The Play button is currently oriented Downwards which doesn't match the orientation of the play button in the Player.

5) In full-screen mode, there's a button to the right of the 'exit fullscreen button' (I'm referring to the second button on the right) that doesn't seem to do anything. What is it?
TagsNo tags attached.
Attached Files
vitreous_header_artifact.jpg (17,182 bytes)   
vitreous_header_artifact.jpg (17,182 bytes)   
Fixed in build1330

Relationships

related to 0006601 closedpetr Panel border behavior is inconsistent 
related to 0006602 closedpetr First navigation toolbar icon should be changed 
related to 0006607 closedpetr Skinning: Player ratings should support transparency 
related to 0006603 closedpetr Strange behavior for panels in main tracklist 

Activities

stephen_platt

2010-10-28 02:54

developer   ~0021037

Last edited: 2010-10-28 02:57

1. Fixed (in latest version if you dock the track browser at the bottom there is a border, but not if it's docked at the top. Petr will need to look at it)

2. I could add this but it will make the seekbar smaller leaving less room for Artist/Title information. Any thoughts about that?
Regarding scrobbler button: that functionality is not implemented yet.

3. I don't follow you. My shortcuts toolbar only has 3 icons. Only 'speaker' icons should be for output plugin config and volume mute icon. I don't see any for collapse to root.

4. That is to visually separate the "Play" vs "Play now" icons, since they have different behavior.

5. It is supposed to switch the view to "Enlarged" video (not full screen and not the small window). Not sure why it isn't working, I'll have to check with Petr.

rusty

2010-10-28 04:16

administrator   ~0021039

1a. I see that Frank's SevenOS skin gets around the lack of a border on top by differentiating the header slightly in color, so that the header itself acts as a border. Do you think that could work in vitreous?

1b. Any idea about why the border to the left of the tracklist doesn't appear next to the column browser? It does show up in SevenOS.

2. You're right that we wouldn't want to shrink the seekbar much smaller, but I was thinking that it would be possible to make space nonetheless. I've attached a mockup--please ignore my artistic skills ;-), but you get the idea. Do you think it's worth pursuing?

3. The 'speaker' icon that I'm referring to is the one that appears as the first icon in the navigation toolbar. It's only function is really as a representation of the root.

stephen_platt

2010-10-28 13:24

developer   ~0021045

Last edited: 2010-10-29 02:15

1a. For various reasons I'd rather not change the color. I'll open a new bug and assign to Petr to see if he can do anything about it. As it is now, the behavior is a bit inconsistent. (0006601)

1b. It's missing on both sides. I noticed that if you start MM4 on Vitreous, then change skin to Blue Glass, then change back, that the problem is gone. I think it's somehow a problem in MM. (0006603)

2. Ok, basically make the volume bar smaller. I will look into it. (implemented but 0006607 needs to be resolved)

3. Okay, I see. If you check other skins, you see they all have a speaker icon here; MM is hardcoded to use menu050.ico in that spot. That same icon represents "mute" and "configure output plugin" icon in the toolbar, so I'd suggest it's changed to use either menu061.ico (same as collapse tree) or have a new icon for that spot. (0006602)

stephen_platt

2010-11-04 03:07

developer   ~0021166

Last edited: 2010-11-11 23:14

4. Fix timer in players

5. Fix ratings

6. Change seekbar to use TextMask=<Summary>

7. Fix tabs per Frank's suggestion

8. Add rollover icon to skin package

stephen_platt

2010-11-13 23:24

developer   ~0021338

All remaining issues fixed except #1, which is now tracked at 0006601 and 0006603

rusty

2010-12-02 21:53

administrator   ~0021569

Stephen, I just tested build 1329 and noticed a couple of small issues:
1) There's a graphical artifact at the tracklist header's junction with the toolbar (see image)
2) The background has the MediaMonkey logo which happens if the background isn't explicitly defined (see image). Is that intentional?

stephen_platt

2010-12-02 23:33

developer   ~0021574

1. Fixed
2. No, that's not intentional. Try the same skin in MM3, it has the correct background. It's the same problem I reported at 0006586 but Petr couldn't reproduce it.

rusty

2010-12-03 19:46

administrator   ~0021597

Re. 2. if you explicitly define the background, this problem should go away (DreadM experienced the same issue with his skins).

rusty

2010-12-06 02:28

administrator   ~0021612

The graphical artifact is fixed in 1330.

The bug re. the background monkeys seems to be an MM issue rather than a skin issue--it occurs on all skins--even the older Glided skin.

rusty

2010-12-06 02:28

administrator   ~0021613

Verified 1330.