View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006615 | MMW v4 | DB/FileMonitor | public | 2010-10-29 21:07 | 2011-04-12 22:03 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.0 | ||||
| Target Version | 4.0 | Fixed in Version | 4.0 | ||
| Summary | 0006615: Add/Rescan dialog UI scans files even when configured not to | ||||
| Description | The Add/Rescan dialog will scan Folders even if the folder is unchecked. This occurs if the 'Scan continuously and at startup' radio button is enabled and the user unchecks the folder for which that Radio Button is enabled. i.e. it seems that the radio buttons take precedence over the checkboxes, and it should be vice versa. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1324 | ||||
|
|
Tested in build 1319 and I cannot reproduce the issue, but there is an issue that could possibly cause the test error. Any 'Scan continuously and at startup' folder was pre-selected and focused when the Add/Re-Scan dialog launched. This could force you to overlook another folder that was checked and thus its scanning started after clicking [OK] button. I fixed the issue in build 1320, i.e. 'Scan continuously and at startup' and 'Scan continuously' folders are not automatically checked and aren't focused. The downside of this is that they can be easily overlooked in the tree. I would suggest to add [x] Hide unselected and unmonitored folders chckbox on the top of the tree? |
|
|
Tested in 1319, and the bug is reproducible in the manner that you describe i.e.: 1) Click <insert> 2) Select a path to some music, click the checkbox and choose the 'Scan continuously and at startup' option. 3) Click OK. -->Scan proceeds 4) After scan is complete, click <instert> 5) Unchecked the path selected at step 2 and click 'OK' 6) Click <insert> -->The path from Step2 is still selected. This makes sense if you consider that the checkboxes in the scan dialog determine whether a scan will take place right away (and that the radio buttons for 'scan continuously' and 'scan continuously and at startup' are completely independent of immediate scans). However, the UI is currently designed in such a way as to imply that unchecking a checkbox will disable all radiobuttons for that folder (i.e. Scan Now=Scan Now, Scan continuously=Scan now + continously, Scan continously and at startup=Scan Now + continously + at startup, and disabling a checkbox ==> all radio buttons are disabled.) The manner in which you've designed it, though, allows the user the freedom to enable an immediate scan independently of what the continous scanning options are. I like that capability, but the UI isn't designed to support that usecase. Possible options: 1) Retain the current logic (mostly), but clarify the UI i.e. a) Select Folders to Add to the Library --> Select Folders to Scan now b) Change scan options section as follows: Folder Scan Options: [ ] Scan continously [ ] Scan at startup Monitored Folders: ...list BUT, I'm not keen on this option because it's not obvious how to enable/disable Continuous scans (i.e. would might think that disabling the checkbox would disable a scan). Also, in the future, we may want to add an option to Remove folders from the library, and this approach is inconsistent with such a feature. 2) Change the logic e.g. Enabling a checkbox should enable/disable whichever of the Scan Options is selected (which implies that a continuous scan cannot be selected unless the folder checkbox is enabled). And ensure that 'Continuous' scanning options also do immediate scans. The downside is that any add/rescan action will always immediately rescan all folders for which 'continuous' scanning is enabled, which means that if the user just wants to manually scan a single folder, they wouldn't be able to without disabling continuous scans on multiple other folders. The second approach is cleaner, but I suspect that the first might be more functional. NOTE: I don't think that the 'hide unselcted and unmonitored folders' option suggested in #c21087 would be that useful (at least as far as solving the problems that I'm describing). |
|
|
Implemented solution 1) in build 1321. Seems to be clear enough to me now. |
|
|
Tested in 1322, and unfortunately, the implementation is still confusing :-(. Specifically: a) When user unchecks a node, it's still a little confusing that the scan options aren't disabled for the node in question (i.e. the text clearly indicates the intenent, but the UI is incongruous with the text). This is a minor issue. b) It's near-impossible to see which nodes have continuous scanning options enabled because there's no indication of this in parent nodes. This is a major issue. --The approach suggested by Ludek of giving an option to hide unmonitored folders could be a workaround, but it's not very friendly. --A second alternative would be to have parent icons of tracks that are continuously monitored display a greyed out version of the icon (similar to how parents of a checked icon show a square). |
|
|
I think that the greyed out versions of the icons would be more confusing than the current approach. What about to add a second tree on the right that would contain list of monitored folders (with corresponding icons) and clicking the folder would be a shortcut to the tree on the left. Folder Scan Options: [ ] Scan continously [ ] Scan at startup Monitored Folders: ----------------- | @ F:\MP3\ | @ C:\Music\ and clicking the @ C:\Music\ node would focus the node in the left tree. |
|
|
Yes--that looks perfect. I would suggest one small change: Folder Scan Options --> Folder Monitoring: |
|
|
Fixed in build 1324. |
|
|
Verified 1363 |
