View Issue Details

IDProjectCategoryView StatusLast Update
0006690MMW v4Framework: Scripts/Extensionspublic2011-02-13 21:55
Reporterzvezdan Assigned To 
PriorityhighSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Fixed in Version4.0 
Summary0006690: OnTotalPlaybackEnd event needed
DescriptionI need an event which would fire when all tracks are finished with reproduction.
Additional InformationIt is not hard to check for such thing using OnPlaybackEnd event when Shuffle is turned off, but it is problematic when Shuffle is turned on because in that case the last played track is not always the last track from the NP list.
TagsNo tags attached.
Fixed in build1346

Activities

jiri

2011-01-25 13:08

administrator   ~0022610

I would call it OnCompleteStop() and it would be called anytime a track playback finishes and there isn't any other track ready to be played.

zvezdan

2011-01-25 13:18

updater   ~0022612

Well, I would be glad if you add such option, not matter how you call it. However, if you don't mind, I have a note about your suggestion. This event is assigned to SDBApplication object, so from its name it is not clear when it is fired (when the application completely stop?). I also would not use the word "Stop", because it could associate someone to the Stop command, I think "End" or "Finish(ed)" is better. How about OnReproductionEnd?

jiri

2011-01-25 13:27

administrator   ~0022615

Ok, OnPlaybackCompleteEnd() might make more sense and would be consistent with the current event.

zvezdan

2011-01-25 13:27

updater   ~0022616

It is too late to change anything, but I think that all events related to the playback (OnTrackEnd, OnPlaybackEnd, ...) would be better with the SDBPlayer object...

Ludek

2011-01-27 21:49

developer   ~0022678

Fixed in build 1346:
http://www.mediamonkey.com/wiki/index.php/ISDBApplicationEvents::OnCompletePlaybackEnd

zvezdan

2011-02-09 22:10

updater   ~0022976

Last edited: 2011-02-09 22:10

This event should be generated if user press Stop, or skip to end of track (i.e. when play counter is not increased), as it is OnPlaybackEnd generated.

Here are steps to reproduce the problem:
1. place two tracks in NP;
2. start playing first track and let it to finish with reproduction normally;
3. few seconds after the second track start with reproduction press Stop -> OnCompletePlaybackEnd is not generated;

Tested in 1348.

Ludek

2011-02-09 22:46

developer   ~0022979

Last edited: 2011-02-09 22:47

I don't think so, from the description here:
http://www.mediamonkey.com/wiki/index.php/ISDBApplicationEvents::OnCompletePlaybackEnd
it does what it is supposed to do.


The event generated when user press Stop is called OnStop:
http://www.mediamonkey.com/wiki/index.php/ISDBApplicationEvents::OnStop

zvezdan

2011-02-09 23:05

updater   ~0022983

Well, you could write your description as you like, but I still think that this event should be fired in same occasions as OnPlaybackEnd, but only for the last track. If you wanted the current behavior, you should called it OnCompleteTrackEnd or OnTrackCompletePlaybackEnd. In my opinion OnCompletePlaybackEnd means the end of playback of all tracks, "because playlist reached its end" as you wrote.

peke

2011-02-13 21:55

developer   ~0023050

Verified 1348

It fires only when playback ended and MM is not in continuous mode.