View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007250 | MMW v4 | Last.fm | public | 2011-01-27 15:34 | 2011-06-18 17:42 |
| Reporter | Ludek | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.0 | ||||
| Target Version | 4.0 | Fixed in Version | 4.0 | ||
| Summary | 0007250: Scrobbling to last.fm when music is played through MM's UPNP/DLNA server | ||||
| Description | This feature should be easy to add as we have already implemented 0007086 | ||||
| Steps To Reproduce | http://www.mediamonkey.com/forum/viewtopic.php?f=6&t=54432&p=284920#p284920 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1376 | ||||
| related to | 0007086 | closed | Ludek | MMW v4 | MM4: Played # increase When tracks are pplayed over DLNA/uPNP |
| related to | 0005671 | assigned | peke | Last.fm plugin | Last-fm plugin: ability to cache/submit playhistory from devices |
| related to | 0007084 | closed | peke | Last.fm plugin | MM4: Played # increase event is called after OnTrack end which results in incorrect Scrobbling |
|
|
Peke, from what I see in our code it looks that this has been fixed together with 0007086, could you verify? I guess so, because this part of code: SendMessage( MainWindowHandle, WM_USER, 1001 {Inc(PlayCounter)}, 603); //This event Announcment will be used with Last.fm plugin is now called in IncreasePlayCounter(), but maybe the scrobbler is missing info for which track the counter should be increased? Maybe we could enhance the message to include also Song ID. |
|
|
In MM3 IncreasePlayCounter() should only be called before on Playback End in MM4 this has changed and thus 0007084 bug. Will revert back to 1341 and how it works there. I was more thinking on something Like 0005664 |
|
|
Can you revert to MM3 it looks that it creates double Scrobbling and incorrect scrobbling when plays are counted if both MM playing track and DLNA servers also increases playcounter. We need to assign different message for that. Assign to me when you revert it back. to see if there is regressions in last.fm plugin itself. |
|
|
I am not sure what exactly do you mean, but it was changed because of issue 0006498 so now it can happen that IncreasePlayCounter() is called several seconds later (once some more important operations are done). Nevertheless I don't see a reason to revert this. If both MM is playing track and DLNA servers also increases playcounter for the same track then I guess that the track should be double-scrobbled, because once it was played in MM and another time via DLNA server, so what is wrong here? Nevertheless if there is really a problem we could possibly add a timeout (1 minute ?) in which PlayCounter cannot be increased for the same track. |
|
|
Peke, any progress on this? I don't see any problem with the Ludek's change. |
|
|
Assigning to Peke. As discussed over IM, standard COM events as provided by MM should be enough for the purpose. |
|
|
Since we need to fix this asap, it was decided to implement the WimAmp compatible messages as suggested by Peke. |
|
|
Fixed in build 1376. |
|
|
Assigned to Peke in order to make appropriate changes in Last.FM plugin |
|
|
Fixed in plugin 1.0.2.25 |
|
|
Tested last.fm scrobbler 1.0.0.25 with MM 4.0.0.1376 and it doesn't work at all. Nothing is scrobbled, and nothing appears in the Log File (last 5 Entries) list. When I click the 'Show Log File' the following error results: Error #-2147024894- File: "C:\Users\...\Appdata\Roaming\MediaMonkey\Scripts\Auto\!LastFM.Options.vbs", Rine: 404, Column: 0 After clicking 'OK', another dialog appears: Error happened during script execution: The system cannot find the file specified. Since this appears to be a separate issue, I'm reresolving this bug, and opening a new one. Note: The above occurs when I install last.fm as a regular user. When I try to install it as Admin, I get the following error during the installation process "Cannot create file C:\Progra~2\MEDIAM~2\Scripts\Auto\!LastFM.Options.vbs. |
|
|
Forum indicates it doesn't work in 1376: http://www.mediamonkey.com/forum/viewtopic.php?p=298009#p298009 |
|
|
Can you send me full plugin Log File. Based on log you posted plugin could not access internet. I'll investigate why it it not returned error after 15 sec. |
|
|
I can't replicate at all plugin correctly stops IE access after 15 sec. I tested in 1382 and 1.0.2.26 can you make me full MM and last.fm log file |
|
|
Hmmm, after though tests today it looks that it is related to 0007653 as uPnP/DLNA scrobbling uses same code for fetching info from MM. |
|
|
Fixed in 1.0.2.27 |
|
|
verified in build 1392 and last.fm scrobbler build 1.0.2.27. Very cool! |
