View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007434 | MMW v4 | Codec | public | 2011-02-22 21:04 | 2011-04-12 21:48 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Windows | OS | XP | OS Version | - |
| Product Version | 4.0 | ||||
| Target Version | 4.0 | Fixed in Version | 4.0 | ||
| Summary | 0007434: MM fails to recognize absence of codecs wrt thumbnail generation | ||||
| Description | On a clean XP machine, upon scanning in a video folder: -no common files played (AVI/MP4) -no warnings were triggered re. the need to download a codec pack -MM kept on trying to generate thumbnails despite the fact that it couldn't (because it couldn't process the vast majority of files) This led to a very poor experience on XP/Vista. What should happen is that MM should recognize that the files in question are missing codecs as soon as it fails to generate thumbnails, then prompt the user to download the codec pack. It might even be worth interrupting the thumbnail generation process e.g. if > 50% of videos can't be processed due to a missing codec, and then re-initiate the process once the codec pack is installed. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1353 | ||||
|
|
Missing codec warning (in case of playback fail) fixed in build 1351. It was occuring in case of missing video codec (e.g. MPEG4 in clean XP) and existing audio codec (e.g. MP3). I think, it is not good to show "missing codec" dialog during scanning/thumb. generating, it may be annoying. I'll better try to optimize the thumb. generation procedure, so it will not try to make thumbnail for files with the same container/video type, for which the thumb generation already failed. E.g. in case of missing MPEG4 decoder it will skip all files with MPEG4 video stream (until next thumb generation processing), in case of missing MKV splitter it will skip all next Matroska files etc. |
|
|
Decreasing priority to improve thumbnails generation. As discussed over IM - there doesn't seem much to be done, just to make it faster in case we miss a codec. |
|
|
Fixed in build 1351. Thumbnail generation optimization (as described above) implemented. |
|
|
Tested in 1351, and although the originally reported usecase is fixed, there are a couple of problem that occur once the user has subsequently installed the codec pack. e.g. 1 Scan Video Folder 1 (contains avi files mainly) --> MM skips thumbnail generation for filetypes as soon as it 'realizes' that it can't process those specific filetypes. Good. 2 Install Codec Pack --> Thumbnails are regenerated, and there's no obvious way to trigger thumbnail regeneration! (Issue 1) 3 Scan Video Folder 2 (contains .mov files) --> Thumbnails generate for the files in Folder 2, but seem to ignore the files in Folder 1. I say this because the status bar shows 'Generating thumnails x/1775', then closes, then re-opens with '... x/1774', then closes, then reopens '... x/1773'.... I.e. each time a new .mov file is scanned in, thumbnails are generated, and MM seems to skip through all the files from Step 1 without generating a thumbnail for them. --> Moreover, many of the .mov files that have been scanned in appear without thumbnails (perhaps failure to scan 1-2 move files caused the thumbnail process to end prematurely??) !! What should happen, is that once a codec pack is installed, MM should retry generating thumbnails for filetypes that previously failed. |
|
|
As discussed with Petr, thumbs are really not regenerated now. I think: 1) we should add some "Generate missing thumbnails" checkbox to "Maintain library" dialog, so user could trigger this action whenever he want to (e.g. after ffdshow installation) 2) maybe it would be good to add some "recreate thumbnail" option to file properties dialog (or video-file context menu?). Good feature would be also to add current paused image as thumbnail (resize, if needed). 3) MM should detect that new codec pack was installed and should trigger thumbnail generation process automatically (the same functionality, as in maintain library - generate missing thumbnails) Rusty, Jiri, what do you think? Please correct features wording then... |
|
|
1) I think it's a good idea to have a way of manually triggering thumbnail creation (the text "Generate missing thumbnails") is fine, but the maintain library dialog doesn't seem like a place that most users would think to use (since it's more about DB maintenance). Looking through the UI, I can't really think of a good location for this function, and wonder if perhaps it would be better to focus on ensuring that this is taken care of by MM transparently. i.e.: - Whenever a scan/file monitor operation occurs - As suggested in 3) whenever a new codec is installed 2) We could add the following context menu commands to any video: 'Save thumbnail' --> a dialog would appear: Generate thumbnail: ( ) Automatically ( ) From current video frame If a video is paused/playing, it would default to the second option, if a video isn't playing, only the first option would be accessible (or better yet, the dialog wouldn't be shown). In both cases, MM would create/replace existing thumbnail. The only problem is that users might be confused re. the difference between the the Add image options and Save Thumbnail option. We had discussed, but rejected combining these two items in bug 0007070. 3) Agreed (see 1)) |
|
|
Upon further discussion with Jiri, we've further refined the suggestion above to: 1) Let's not implement 'Generate missing thumbnails' function, and instead focus on making MM take care of this so that the user doesn't have to. The way this could work is that MM would trigger background thumbnail generation when it detects that thumbnails are missing: AND any of the conditions occur: a) MM was restarted b) User initiates a scan and video is added c) User installs an Addon (as a proxy for a Codec Pack) d) User attempts to add a thumbnail manually (see 2)) 2) Add the following context menu commands to any video (just below the 'Add image' command): 'Save thumbnail' --> a) If a video is playing/paused, a dialog would appear: . Generate thumbnail: . . ( ) Automatically . . (o) From current video frame b) If a video isn't playing, the thumbnail would be generated automatically. In both cases, MM would create/replace existing thumbnail. |
|
|
Setting as Immediate to at least add the string for localization. |
|
|
Implemented in 1352 |
|
|
Saving current frame saves only black picture for me in XP, I will look at it. |
|
|
Fixed in build 1353. |
|
|
Verified 1363 |
