View Issue Details

IDProjectCategoryView StatusLast Update
0007703MMW v4Otherpublic2011-05-29 01:06
Reporterlowlander Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version4.0 
Target Version4.0Fixed in Version4.0 
Summary0007703: Add/Rescan Folders defaults to selecting My Music
DescriptionWhen you open Add/Rescan Folders without any folders selected (happens when you scan Media Server in previous scan) it will start with the My Music folder selected despite that it wasn't selected before.
This is especially annoying as there is no easy way to see which folder(s) are selected for scanning.
Additional Informationhttp://www.mediamonkey.com/forum/viewtopic.php?f=6&t=57525
TagsNo tags attached.
Attached Files
addrescan multiple.jpg (18,511 bytes)   
addrescan multiple.jpg (18,511 bytes)   
Fixed in build1376

Activities

jiri

2011-05-02 09:52

administrator   ~0024716

I think we should consider a small improvement even for 4.0, it really can be a little hard to see what's exactly selected for scanning.

I think that the best option would be to show even folders that will be scanned once in 'Monitored Folders:' list. They would have a specific icon and would have a new checkbox above. We would probably need a new localized string though.

I think that in case we improve this, the original issue described will no longer be an issue.

rusty

2011-05-02 21:10

administrator   ~0024736

Last edited: 2011-05-02 21:11

I don't think that it's necessary to modify the functionality for a couple of reasons:

1) The root folders of the Tree show what items have subfolders checked off, so it is easy to see what items are checked off.

2) The issue of folders being selected automatically for scanning _should_be_ a 1-time issue--i.e. folders should be automatically selected only on the initial scan (after install). If this isn't the case, it can be easily fixed.

3) I think it's cleaner to show the 'Monitored folders' on one side of the dialog (rather than mixing monitored folders and 1-time scans).

lowlander

2011-05-02 22:52

developer   ~0024745

1) I have up to 8 drives and several network locations, and folders all over the place. Having to scroll through a huge list makes it a lot of work to find which folders are to be scanned.
If you have a simple static setup or one with just one location this isn't much of an issue. But with many drives/locations and the inadvertent selection of folders in the Location node causing it to be set as scan folder (which I find both very useful and annoying) it's a hassle to have to scroll around to find which folders have been selected. MM3's simple textbox gave us that overview and MM4 no longer does.

2) This is the original bug report

3) Although I agree with that, it could be done with a separator. Below (or the other way around) the separator all folders that will be scanned and above all that will be monitored. Selecting folders to be scanned would allow to add monitoring to them.

jiri

2011-05-03 07:07

administrator   ~0024760

I think that something along lowlander's 3) suggestion would work well and improve usability of the dialog. Rusty?

rusty

2011-05-03 14:31

administrator   ~0024771

Re. 1)/3), I think I see what you mean--are you saying that because MM persists which folders were last scanned manually, MM should better display those folders since the user will have forgotten which ones have been persisted? (from my perspective, there's no need to display which folders have been selected in the right hand side for folders that have just been selected, but I could see an argument for better displaying folders that were previously selected and perhaps forgotten).

If that's the point of this, we could go the suggested route, but I think the UI would make the file monitoring functionality very confusing. e.g. the right-hand side would look something like this:

Folder Monitoring:
[ ] Scan continuously
[ ] Scan at startup

Folders to manually scan:
....
....
....
Monitored Folders:
...
...
...

From my perspective, this really confuses the File Monitoring UI.

An alternative approach that maintains a separation between the concepts of manual scans and monitoring, could be: In the tree, add an accordion-style root node for:
 [ ] Selected folders

It would contain whatever nodes have been selected, and can only be expanded to the mutual exclusion of the My Computer accordion-style root node.

This is much cleaner, but would require a new control.

lowlander

2011-05-03 15:01

developer   ~0024773

Yes, both the remembering previously selected folders as well as the auto-selection of Location node folder can be hard to confirm in the current setup.

Either proposed solution from Rusty works as long as it's shown clearly as to what will be scanned. Option 2 has the benefit that it would make the Add option more consistent. Currently selecting a node just sets the checkbox while Add adds it to the bottom.

jiri

2011-05-03 16:14

administrator   ~0024776

As discussed over IM with Rusty, probably the simplest solution that doesn't even need a new string is to show a new checkbox:

 [ ] Hide unselected items

in the same way as it's already implemented in Device Sync Configuration.

Ludek

2011-05-04 23:02

developer   ~0024845

Fixed in build 1370.

jiri

2011-05-09 09:50

administrator   ~0024957

On resize, position of the new checkbox is fixed.

Ludek

2011-05-09 10:16

developer   ~0024959

Fixed in build 1371.

lowlander

2011-05-11 14:37

developer   ~0025085

Last edited: 2011-05-11 20:01

1) MediaMonkey still selects My Music by default (outside of the initial scan):
1 Open Add/Rescan Files
2 Deselect all folders
3 Click OK
4 Open Add/Rescan Files and My Music is selected again

2) Also with Hide Unselected Items it shows the Network node (child node of My Computer), but not the Media Servers node. I would have no problem that if nothing is selected nothing (even My Computer) is shown.

3) (Regression) When typing in the Add box I would expect Enter to Add the value instead of initiating Add/Rescan.

4) Removing items when Hide Unselected Items is enabled doesn't remove them from view, you'll have to unhide/hide to achieve that.

rusty

2011-05-11 20:03

administrator   ~0025094

1) Small issue, but should be fixed (high)
2) Small issue, but should be fixed (high)
3) Urgent issue--usability regression
4) Should not be fixed--I think that the current behaviour is preferable to the proposed alternative since users would have a tough time with the tree jumping around and would be unable to undo deselection errors.

Ludek

2011-05-11 20:32

developer   ~0025097

Fixed in build 1373.

lowlander

2011-05-12 16:58

developer   ~0025123

Fixes for issues 1-3 verified in 1373.

lowlander

2011-05-13 20:59

developer   ~0025197

Last edited: 2011-05-13 21:01

5) After using Add button focus is lost from textbox (you can't keep typing in it)

6) User can add same Location several times (http://www.mediamonkey.com/forum/viewtopic.php?f=6&t=55772)

7) It seems that after adding server location to be scanned that after restart Add/Rescan Files just shows \\ (instead of \\IP\folder) and this can't be removed.

Ludek

2011-05-16 11:34

developer   ~0025325

Last edited: 2011-05-16 11:35

5) I cannot reproduce, here are the steps:
a) focused the edit line in order to type
b) started typing
c) pressed Enter key to enter the folder
=> cursor stays in the edit line as expected and I can continue typing without a problem

Note: If you mean that you left the edit line by clicking on the [Add] button then it is standard behaviour.

6) Fixed in build 1376.

7) I cannot reproduce, added \\192.168.0.1\Folder1\Folder2\ and the node stays there exactly as were inputed

lowlander

2011-05-16 15:21

developer   ~0025336

Last edited: 2011-05-16 15:22

5) yes, I meant using the mouse.

7) I haven't seen it again so far

lowlander

2011-05-18 15:56

developer   ~0025408

6) Verified in 1376, user can't add same location. I think it would be nice though if the Add button remains disabled while the same location as already added is present in the text box or an error is shown on using Add for same location that the same location can't be added twice.
Also user can add a location that is already selected in the Tree via pre-existing nodes.

Ludek

2011-05-18 16:07

developer   ~0025417

Last edited: 2011-05-18 16:07

Re: 6) [Add] button remains disabled in my case:
 - type a location,
 - hit enter key
=> [Add] is disabled

lowlander

2011-05-18 16:31

developer   ~0025429

6)
 - type a location,
 - hit enter key
 - [Add] is disabled
 - Remove last character
 - Retype it
 - Add is enabled

Ludek

2011-05-18 18:21

developer   ~0025435

OK, leaving resolved, not a grave issue.

stephen_platt

2011-05-29 01:06

developer   ~0025746

verified 1381