View Issue Details

IDProjectCategoryView StatusLast Update
0007729MMW v4Otherpublic2011-09-08 00:27
Reporterlowlander Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version4.0 
Target Version4.0Fixed in Version4.0 
Summary0007729: Alignment of OK/Cancel buttons in the various dialogs
DescriptionThere is an inconsistency in the way OK/Cancel are aligned in the various dialogs. This was tested on 1369 on XP.
Steps To ReproduceDialogs with obvious issues:
Auto-Organize Files (right margin incorrect)
Auto-tag from Filename (right margin incorrect)
Auto-Tag from Web (left/right margins incorrect from other Auto-Tag dialogs)
Edit AutoPlaylist (buttons aligned wrong)
Playlist Criteria (too much right margin)


Dialogs that chose center instead of right alignment:
Enter URL
Equalizer Options
Maintain Library
Output plugin
TagsNo tags attached.
Attached Files
workspace.jpg (29,861 bytes)   
workspace.jpg (29,861 bytes)   
warning_question.jpg (7,691 bytes)   
warning_question.jpg (7,691 bytes)   
vertical alignment.jpg (102,416 bytes)   
vertical alignment.jpg (102,416 bytes)   
Fixed in build1376

Activities

jiri

2011-05-04 20:03

administrator   ~0024836

Rusty, before assigning to Ludek, please review whether we should adapt a standardized right alignment and use it in all dialogs.

We should formalize the standard then and store it e.g. in our wiki.

rusty

2011-05-06 14:57

administrator   ~0024897

Last edited: 2011-05-06 14:58

In Windows, there are generally two conventions (see attached examples):

1) for dialogs in which work/configuration is actually done, the convention is to right-justify OK-Cancel (though preferred wording is <Action>-Cancel, but that's for another time).

2) for dialogs in which the user is being prompted to decide among 2 alteratives, the convention is to center-justify the possible alternatives.

All of the issues that Lowlander describes fall into the first category, so they should be right-justified.

Note: for 'Enter Url' dialog, the [Browse...] button should be moved to the right of the text box.

Ludek

2011-05-09 12:08

developer   ~0024963

Fixed in build 1371.

lowlander

2011-05-11 14:30

developer   ~0025084

Verified fixes in 1371. Options for Equalizer seems to have less than standard spacing between OK and Cancel.

Ludek

2011-05-11 20:06

developer   ~0025095

Fixed in build 1373.

lowlander

2011-05-12 19:08

developer   ~0025131

Verified in 1373

lowlander

2011-05-13 20:13

developer   ~0025189

There also is vertical alignment issues (see screenshot vertical alignment).

lowlander

2011-05-13 22:40

developer   ~0025209

The AAC, M4A, M4B, MP4 (not MP4 video) conversion windows windows are cutoff: http://www.mediamonkey.com/forum/viewtopic.php?f=6&t=55582

Ludek

2011-05-15 20:13

developer   ~0025274

Last edited: 2011-05-15 20:13

Fixed in build 1376.

Note that there were needed some changes in the MP4/AAC addon too.

lowlander

2011-05-18 16:13

developer   ~0025420

Where can one obtain the new MP4/AAC to test this fix?

stephen_platt

2011-05-19 18:09

developer   ~0025494

It's been uploaded to FTP.

lowlander

2011-05-19 20:15

developer   ~0025498

Last edited: 2011-05-19 20:15

Don't have access to that so someone else will need to confirm.

peke

2011-09-08 00:27

developer   ~0027490

Verified 1428 and 2.14