View Issue Details

IDProjectCategoryView StatusLast Update
0007829MMW v4Framework: Scripts/Extensionspublic2011-10-02 22:30
Reporterrusty Assigned To 
PriorityimmediateSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Product Version4.0 
Target Version4.0Fixed in Version4.0 
Summary0007829: Switching languages --> AV
DescriptionSwitched languages to Espanol (download) and restarted MM --> AV.
Additional InformationSubmitted 2 Elogs.
TagsNo tags attached.
Attached Files
7829.dat (56,151 bytes)
failed_language_install.jpg (12,917 bytes)   
failed_language_install.jpg (12,917 bytes)   
error-message-01.jpg (13,636 bytes)   
error-message-01.jpg (13,636 bytes)   
error-message-02.jpg (18,631 bytes)   
error-message-02.jpg (18,631 bytes)   
Fixed in build1433

Relationships

related to 0007846 closedLudek Cannot install last.fm extension 1.0.0.25 
related to 0007867 closedjiri Error dialogs on MM startup have buttons without any text 
related to 0008199 closedpetr Some language files are broken 
related to 0008548 closedpeke On DB Upgrade Permitions are inherited instead updated/renewed 
related to 0010719 closedpetr Crash on skin install 

Activities

jiri

2011-05-17 08:56

administrator   ~0025351

I can't reproduce. Petr, based on the ELs, probably assign to Ludek.

Ludek

2011-05-17 14:50

developer   ~0025360

Last edited: 2011-05-17 14:51

I fixed the AV, but it was caused by another problem, it looks that MM couldn't access file
C:\ProgramData\MediaMonkey\Locale\fr\LC_MESSAGES\language.mo
that MM needed to delete and extract new content to the file.

I also realized that error reporting was turned off, I enabled the error reporting so that you could see the error when installing language.

rusty

2011-05-18 15:42

administrator   ~0025404

Note also, user reported that in 1375, upon downloading files, the only file that appears downloaded is \Users\All Users\MediaMonkey\Locale\sk\LC_MESSAGES\language.mo (the others are all missing).

rusty

2011-05-18 15:47

administrator   ~0025406

Last edited: 2011-05-18 15:49

Tested with 1376, and some languages (e.g. CZ) generate the following error:
Cannot create file C:\ProgramData\MediaMonkey\Locale\cs\LC_MESSAGES\language.mo

Could this be related to 0007846 (installation problem with scrobbler .mmip)?

Related tweak: the message dialog has no text in the buttons (see attached).

Ludek

2011-05-18 20:54

developer   ~0025449

Last edited: 2011-05-18 20:59

As discussed over IM, the problem is that something (most probably MM itself) opens language.mo file and then it cannot replace the file.

Although I cannot reproduce the problem, the most correct solution would be to update all language MMIP so that language.mo would be replaced only if the file doesn't exists. This covers also possible conflicts when more than one instance of MM is running, because the info from language.mo is used when showing the Options dialog.

rusty

2011-05-18 21:26

administrator   ~0025450

Tested further, and I think that your hypothesis is correct. On a couple of occasions (this isn't consistent), after I'd switched languages, I switched nodes in the Tools > Options dialog before accepting the change, and then switched around MM nodes. Then upon restarting, I didn't get the error.

I'm baffled as to what specifically causes the error to not occur, though.

Ludek

2011-05-18 22:02

developer   ~0025452

Last edited: 2011-05-18 22:04

Finally I found a better solution that doesn't require any modification of language MMIPs.

Fixed in 1377.

rusty

2011-05-18 22:25

administrator   ~0025454

Test note: on my system there is both C:\Users\All Users\MediaMonkey AND C:\ProgramData\MediaMonkey. Languages pre-installed with MM appear in AllUsers and languages that are downloaded appear in ProgramData.

Ludek

2011-05-18 22:49

developer   ~0025458

This should depend on registry value
HKLM\Software\Microsoft\Windows\CurrentVersion\Explorer\Shell Folders\Common AppData

Maybe the value somehow gets changed on your system?

peke

2011-05-18 23:14

developer   ~0025460

Note I also have both folders.

rusty

2011-05-19 14:34

administrator   ~0025487

Possibly related item: one user is receiving 'script engine' errors on language file installation. See attached images.

rusty

2011-05-23 02:06

administrator   ~0025561

Last edited: 2011-05-23 02:12

Tested build 1378 and the errors occur exactly as reported in build 1377.

Note: tested on a different machine. both machines were Win7 x64.

Ludek

2011-05-23 08:50

developer   ~0025563

Last edited: 2011-05-23 08:56

I fixed all the language packages so that language.mo file is overwriten only when it doesn't exist and so that language.mo isn't removed when uninstalling language . This is correct and will resolve the problem although it would be valuable to find the real reason of the lock. Jiri is trying to find it as he can reproduce the problem.

jiri

2011-05-23 09:28

administrator   ~0025565

I found out that the problem is caused by the fact that the language.mo files are created during installation of MM and so their owner is 'Administrator'. Ordinary users can't edit these file and so the replacement fails. The Ludek's fix should help and in order to be safe, I also modified the installer, so that the language files are created with full permissions.

Testing note: installation in the normal and portable mode should be tested to make sure no regression was introduced.

rusty

2011-06-06 04:04

administrator   ~0025944

Verified 1384.

rusty

2011-09-12 16:06

administrator   ~0027611

This error seems to be occuring again (with a slight variation on the previous error--this time it's associated with context.mo). i.e. install a language vX, and then install vX+1 -->

Cannot create file C:\ProgramData\MediaMonkey\Locale\<lang>\LC_MESSAGES\context.mo

Ludek

2011-09-13 12:04

developer   ~0027658

Last edited: 2011-09-13 18:39

I can reproduce the error this way:

1. Right-click MM and 'Run as administrator' and install the language (by double clicking MMIP) and close MM
2. Run MM normally by double-clicking and install the language
=> error (as expected)

Ludek

2011-09-13 18:37

developer   ~0027680

Last edited: 2011-09-14 00:39

Fixed in build 1433.

Testing note: The fix was that it sets file permissions to everyone when copying the file from installer, it means that for already created files the fix doesn't work unless the language is re-installed with admin rights.

peke

2011-10-02 22:30

developer   ~0028011

Verified 1439