View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007844 | MMW v4 | Burning / Disc Handling | public | 2011-05-18 14:51 | 2011-06-07 21:51 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 4.0 | ||||
| Summary | 0007844: Scripts that uses Toolbar is listed as 'TBStandard' instead of 'Standard' | ||||
| Description | When the user installs the last.fm plugin, a toolbar is added to MM to control scrobbling, however, it is labelled as 'TBStandard' instead of 'Last.fm Scrobbler'. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1378 | ||||
|
|
This is compatibility issue 'TBStandard' is from MM3 due you wish that I create new toolbar with when installing in MM4? |
|
|
1. Imported Toolbars from MM3 Should be automatically recognized as Standard 2. All Scripts that work with both Mm3 and MM4 that uses toolbars which are removed from MM4 should be correctly named ( see Menu_tb* naming from http://www.mediamonkey.com/wiki/index.php/ISDBUI::Menu_Compendium ) |
|
|
FYI, Lyrics Viewer and MonkeyRok scripts both add Toolbar icons, which are placed in 'TBStandard' toolbar in MM4. |
|
|
Peke, I fixed it in the plugin (it is in SVN), but I forgot for compatibility issues with MM3. So please revert my change or adjust by checking MM version and use the new AddToolbar method only for MM > 4.0 |
|
|
Fixed the compatibility issue so that MM4 shows the 'Last.FM Scrobbler' while MM3 still works. |
|
|
confirmed that it is internally fixed for Last.fm plugin only (by making 0007852 and adding correct check in "!LastFM.Options.vbs" like Ludek pointed in his comments which is desired behavior like Rusty pointed), but like gage pointed in his comment http://www.ventismedia.com/mantis/view.php?id=7844#c25478 not fixed for any other plugins/scripts that uses menu_tbstandard to show toolbar icons which break compatibility with all of those MM3 plugins/scripts that normally work in MM4 without any additional changes. Which render my original comment issues not fixed http://www.ventismedia.com/mantis/view.php?id=7844#c25448 and instead of Localized Standard Toolbar name for all languages MM shows TBstandard. |
|
|
Moved to 'MediaMonkey Current' since the issue is generic to all plugins. |
|
|
last.fm plugin version info updated to 1.0.2.26 NOTE: Due the current design of 0007613 there is chance that for some users two last.fm icons are show. Solution would be to clean install last.fm plugins (eg uninstall and than install latest again) |
|
|
Fixed in build 1378. Note that the same issue was with Advanced, Categorize and Edit toolbars. |
|
|
Verified 1385 |
