View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008648 | MMW v4 | Conversion/Leveling | public | 2011-11-06 22:08 | 2012-12-22 02:36 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.0 | ||||
| Target Version | 4.1 | Fixed in Version | 4.1 | ||
| Summary | 0008648: Accurate rip error condition workflow needs improvement | ||||
| Description | In the case of an AccurateRip failure, the message given is: "This CD doesn't exist in the database or there is a problem with your internet connection." This should be split into two different error messages: 1) "This CD doesn't exist in the database. [OK]" 2) "There is a problem with your internet connection. [Retry] [Cancel]" | ||||
| Additional Information | http://www.mediamonkey.com/forum/viewtopic.php?f=6&t=61662 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1601 | ||||
|
|
Fixed in build 1600. |
|
|
Re-opened, there is one important string that needs improvement, currently if the CRC checksum doesn't match then MediaMonkey shows: "Track D:\Track01.cda failed to verify (ripped inaccurately)" this is not correct, because there are at least three other reasons why the CRC checksum doesn't match a) It is a different pressing of the same CD b) The submitter's CRC was ARv2 and MM compares only ARv1 checksum (tracked as 0009125 ) c) The first (and only) submitter ripped CD inaccurately So in summary the only that we can say (if the CRC doesn't match) is that CD cannot be veryfied against AccureteRip database, therefore the correct string should be something like: "Track D:\Track01.cda could not be verified, the checksum doesn't match (this doesn't necessary mean that the rip was inaccurate)" Rusty, could you confirm/adjust the string? |
|
|
Shouldn't we have different messages for the various cases? e.g. 1) <Track> verification failed (connection problem) 2) <Track> verification failed (bad rip) 3) <Track> verification failed (multiple versions of the CD exist) 4) <Track> verification failed (data cannot be compared) 5) <Track> verification failed (insufficient data in the accuraterip DB) - used in case of failure when only a single record is compared |
|
|
The problem here is that we cannot know which case it is, we only know that CRC doesn't match, but we can hardly guess the real reason. i.e. we cannot know whether submitted data is inaccurate or whether it was another CD pressing or whether our rip was bad. The only that we know is that we got different result |
|
|
OK, so that means that MM can't distinguish between the following cases: 2) <Track> verification failed (bad rip) 3) <Track> verification failed (multiple versions of the CD exist, and submitted data only exists for one version) 5) <Track> verification failed (submitted data is inaccurate) In which case we could use the following error message: "Track D:\Track01.cda not verified (bad rip or the database has partial/inaccurate data)" |
|
|
Fixed in build 1601. |
|
|
I just tested this out, and noticed one more issue: When a CD is successfully ripped, but an AccurateRip error condition arises, the following appears: There was a problem ripping the following Track(s): <Track> failed to verify, <error condition> This implies to the user that the rip failed, when in fact it hasn't. Possible solutions: 1) Change the following string, and use it instead: Track(s) have been verified against AccurateRip.com database with the following results: --> Track(s) have been compared against AccurateRip.com database with the following results: BUT, will that work in all cases? i.e. what happens when some tracks fail to verify, and others fail to rip--is a single dialog presented for both? If yes, another approach could be... 2) Change There was a problem ripping the following Track(s): --> There was a problem ripping or verifying the following Track(s): This only works if all track-level error messages are specific as to what the error is. |
|
|
Rusty, I implemented 2) wording change to the leading dialog text i.e. "Track(s) have been verified against AccurateRip.com database with the following results:" appears when there was clearly no error, i.e. 'Track %s verified with confidence number %d (number of people matched your rip)' "There was a problem ripping or verifying the following Track(s):" appears when there was a ripping or verification error: e.g. 'Track %s failed to verify (bad rip or the database has partial/inaccurate data)' 'Track %s failed to verify (error parsing verification file)' 'Track %s failed to verify (track isn't present in database)' 'Track %s failed to verify, this CD doesn't exist in the database' 'Track %s failed to verify, there is a problem with your internet connection' Fixed in build 1601. |
|
|
Verified 1615 |
