View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017779 | MMW 5 | Conversion/Leveling | public | 2021-04-21 16:25 | 2024-02-28 17:40 |
| Reporter | Ludek | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.0 | ||||
| Target Version | 5.1 | Fixed in Version | 5.1 | ||
| Summary | 0017779: Unanalyzed volume node tweaks / improved approach to Album Volume | ||||
| Description | Testing the 'Files to Edit > Unanalyzed volume''node because of issue reported at https://www.mediamonkey.com/forum/viewtopic.php?f=30&t=98859 and seeing: 1) Unanalyzed volume lists also deadlinks, this used to be the case in MM4 too, is that's intentional ? 2) Selecting a single file under the Unanalyzed volume node > right-click > Analyze volume => only 'Track volume' is calculated (even when MM is configured to analyze also Album volume) => thus the track does not disappear from the list of unanalyzed files Testing in MM4 and it works same way in the MM4, is this intentional? Shouldn't MM always calculate the album volume (even when a single track is selected to calculate the volume) ? 3) User reported that list grows with files being played (i.e. a refresh issue falsely adding files to the list after playing), I am unable to replicate this so far though EDIT: After some further tests I am able to replicate | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2824 | ||||
| related to | 0019995 | closed | michal | Some tracks in Unanalyzed Files cannot be analyzed |
| related to | 0013444 | assigned | rusty | Facilitate leveled playback so that it occurs automatically |
| related to | 0014209 | new | Allow user to set Album Volume calculation per Disc or per Album (all discs) | |
| related to | 0018003 | new | michal | Improved reporting of problems with volume leveling tags |
| related to | 0020675 | closed | Ludek | Album level value is calculated even for files with unknown album value |
|
|
Item 3 is fixed in 5.0.1.2400 Rusty, I am not sure about items 1&2 -- as these bugs exist in MM4 too and this functionality has been developed before I joint the MM team, can you please review what is the correct/intentional behaviour here ? |
|
|
1) Re. deadlinks: I suppose that we should take a common approach for _all_ files to edit nodes. e.g. Unknown Artist / Unknown Rating etc. should all work in the same manner. My intuition is that just as deadlinks/inaccessible files normally appear in the library, they should appear in these nodes as well and the user can user Filter functionality to filter them out if so desired. What could be interesting is to associate these nodes with a filter. e.g. if this node was activated with a filter to hide inaccessible and the user could then easily disable it if desired. 2) This may require a separate bug, but we can continue the discussion here until we decide that a change is really needed: I think that most users would expect that the logic for analysing a track's volume in this node would be the same as the logic for analyzing a track's volume elsewhere in the library. So the question becomes how should MM handle volume analysis when only a subset of tracks on an album are chosen to be analyzed (which might often be the case for tracks in the 'Unanalyzed volume' node, and is likely always the case for automatic volume leveling). I'm not sure whether MM is already doing this or not (0001330 seems to indicate that it doesn't), but the most desirable approach would probably be one similar to that used when the user attempts to save album art for only a single track on an album: in that case, the user is asked whether to '[ ] Apply to all files in the album/series'. In the case of attempting to apply Album Volume leveling when only a single track is chosen, a similar approach can be taken i.e. - MM should analyze all files in the album/series - To correct for cases in which there are duplicate tracks from the same album, we may want to include logic so that only one instance of the duplicate (preferably the one in the same directory as the majority of tracks from the album) should be included in the Album Volume calculation (other instances should probably be treated as independent?). We could make this an optional config entry: [ ] Album Volume analysis: Apply to all files in the album/series But I don't think it's really necessary. |
|
|
ok, moving target for 1&2 out of 5.0.1 |
|
|
1) Agreed. 2) Yes, I'd say that we should always analyze the entire album. I suppose that this will be ok for most users, even though there might be some special use-cases, where the option to disable this would be welcomed. I'd consider adding such an option only if we get a significant amount of requests from users. |
|
|
Based on the feedback at https://www.mediamonkey.com/forum/viewtopic.php?t=105240 , it appears that item 2 was implemented but without any UI! i.e. now, if Options > Volume leveling > 'When analyzing Track volume, also analyze Album Volume' is enabled, then selecting a single track to Analyze causes all the tracks on the album to be analyzed. While I think that this is reasonable behavior, it's confusing without the associated UI for the reason described in the forum. As an alternative to the original suggestion in this bug, we may want to make the following changes that negate the need for a UI and user interaction for each operation. The approach suggested below is that MM is always expected to analyze both Track and Album volume whenever volume analysis is performed, except that in the case of partial selection of an album, the user can configure whether or not to perform Album volume analysis. i.e. the changes would be: 1) Change 'When analyzing Track volume, also analyze Album Volume' --> 'Analyze Album volume even when only part of an album is selected' If enabled (and it can be enabled by default), then when the user selects a single track from an album, then all tracks are analyzed (depending on 'Only analyze files with unknown Leveling Adjustment). If disabled, then Album volume analysis is only carried out if all tracks on the album were selected to be analyzed. i.e. - Selecting all files analyzes album volume - Selecting partial files doesn't analyze album volume |
|
|
And a tooltip can explain that this will also analyze unselected files on Albums of selected files. Alternatively we could add a sub-option to Album Volume 'Also analyze unselected files on Albums of selected files'. With a tooltip explaining that this is needed to calculate the Album Volume for selected files. |
|
|
Should I understand it that auto-analyzer should _always_ normalize album volume with the new config ? Isn't it better to stick with current: 'When analyzing Track volume, also analyze Album Volume' which allows to disable album volume analyzing altogether? Is there any downside with current approach? Maybe the string "'Analyzes Album volume even when only part of an album is selected'" should be just tooltip for current 'When analyzing Track volume, also analyze Album Volume' checkbox? |
|
|
You're probably right. It seems that the behavior from 5.0.4 is well understood. But I still think it's buggy, so perhaps (as I suggested in the forum) we should just retain the 5.0.4 behavior unless the new option below is enabled. e.g.: [x] Only analyze files with unknown Leveling Adjustment [ ] Automatically analyze volume of unanalyzed files [x] When analyzing Track volume, also analyze Album volume . . [x] Analyze all tracks on the album In other words, enabling the new option would trigger the behavior that's currently implemented in 5.1. If the new option is disabled, then the question is what should happen in case the user selects a subset of the album. Possible options: a) Generate an incorrect Album leveling value b) Leave the Album leveling value empty c) 5s Toast message e.g. 'Some of the selected files are subsets of an album. Include all tracks (for accuracy)? [[Yes]] [No]' (might not be possible in the short term). Thoughts? |
|
|
BTW: The logic to always analyze whole albums (in 5.1) was because of issue 0019995 so adding the new option would result in 0019995 to be unresolved again :-/ Isn't it enough to leave the current logic in 5.1 and just better communicate that the checkbox [x] When analyzing Track volume, also analyze Album volume is causing whole albums to be analyzed even if only part of tracks have been selected? Either via the toast message or the tooltip? |
|
|
Another option that is suggesting a user on the forum is, that MM 5.1 should calculate album volume just once the tracks are selected under the Unanalyzed volume node > right-click > Analyze volume This way it would keep item 2) resolved (same as 0019995 ) but retain the 5.0.4 logic for the other nodes (to analyze only subset of album without calculating album volume).. |
|
|
I don't think it makes sense for the command to work differently depending on the node, so that's not an ideal solution. As to the approach suggested at 0017779:0073452 breaking 0019995 you raise a good point. But the solution of better communicating the behavior doesn't solve the issue that some users want to be able to choose on-the-fly whether Album Gain should be calculated for related tracks (either by selecting all tracks on an album OR by some sort of intermediate option). So perhaps we should just leave the options as they currently appear in 5.1, but in the case that Album volume is enabled and the user selects a subset of tracks on an album, use a 10s toast message: 'Album leveling is enabled, which will cause <number> other tracks to be analyzed. [Exclude these tracks]' So if 'Exclude' is clicked, and analysis of a 'full' album containing 'other' tracks has already begun, then that album should be completed and all subsequent 'other' tracks shouldn't be included. And the status bar should be updated accordingly. |
|
|
ok, implemented as suggested in build 5.1.0.2824 |
|
|
Verified 2832 |
