View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0013486 | MMW v4 | Framework: Tagging | public | 2016-08-31 10:31 | 2016-09-13 21:47 |
| Reporter | michal | Assigned To | |||
| Priority | immediate | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.1.13 | ||||
| Target Version | 4.1.14 | Fixed in Version | 4.1.14 | ||
| Summary | 0013486: Alternating editing of M4A/ALAC tags in MM and Tag&Rename application can cause file damage | ||||
| Description | When using M4A/ALAC files from issue 0013484 and related user ticket I have found out, that alternate editing of tags in MediaMonkey and Tag&Rename 3.9.8 causes file damage. We should make sure, that MM writes really standard tag here and try to avoid file damage as much as possible. More info at: http://atomicparsley.sourceforge.net/mpeg-4files.html https://sourceforge.net/u/geyan123d/freepiano/ci/c82a65fdaaf19b528ce2eb4801c16b2aed3aceb1/tree/3rd/mp4v2/mp4meta.cpp | ||||
| Steps To Reproduce | 1) edited comment in Tag&Rename 3.9.8 (added some chars) - result: file seems to be ok 2) edited comment in MM4 (added some chars) - result: file seems to be ok 3) edited comment in Tag&Rename 3.9.8 (removed chars from 2)) - result: file is not playable in MM4, file has wrong format (size of some atoms in the file header is not correct). 4) edited comment in MM4 (removed chars from 1)) - result: the file is damaged, audiodata are lost. We should avoid this, if possible. | ||||
| Additional Information | CPK-872-11393 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1809 | ||||
|
|
The main problem is really in Tag&Rename 3.9.8, at least with atom moov.udta.meta.ilst.disk.data. MediaMonkey stores it as 24 bytes and correctly writes this size, but Tag&Rename ignores stored size of this atom and behaves like it would have 22 bytes. This shifts all data by 2 bytes and after writing tags by T&R the file is not in consistent state. I will try to better detect this kind of corruption, so MediaMonkey will refuse tag editing of such files, instead of making more damage (4). |
|
|
Our part (4) fixed in build 1807. It will not save tags to files in case it detects such serious problems in the file. |
|
|
Verified 1807 |
|
|
Reopen I have found few strange tagging issues and MMW refresh behavior. NOTE: original issue is fixed, but I maybe have found why all that is happening. |
|
|
Mentioned tagging issue tracked as 0013513 |
|
|
Changed disk.data atom, so MM now writes it as 22B atom too (i.e. 6B of payload), it seems, iTunes and other tagging apps decided to write it this way (but trkn.data with track number still has 8B payload, no idea why). Resolving, it should be all ok now. |
|
|
Mentioned and inconstancy of MMW showing the tags for M4A were manifisistation of 0013513 issue. Resolving |
|
|
Verified 1809 |
