View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0013579 | MMW 5 | General | public | 2016-10-06 22:03 | 2017-11-23 00:51 |
| Reporter | Ludek | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 5.0 | ||||
| Summary | 0013579: Options > Metadata Lookup isn't respected | ||||
| Description | The default values in Options > Metadata Lookup [ ] Search for missing lyrics automatically --[ ] Save missing lyrics automatically [ ] Search for missing artwork automatically --[ ] Save missing artwork automatically but currently this options aren't respected and MM5 always auto-lookups artwork in various portions of MM5 UI. Currently only A&D window seems to respect the settings. This should be revised and also the default values needs to be re-classified. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2083 | ||||
| related to | 0013695 | closed | jiri | Tools for editing artwork are inconsistent / redundant |
| related to | 0013406 | closed | Ludek | NP Art & Details dialog improvements |
| related to | 0014124 | closed | jiri | Lyrics View: Lyrics View can't be closed and auto search lyrics is executed even it is disabled |
| related to | 0013562 | closed | michal | Inconsistencies in Artwork display |
| related to | 0013727 | closed | michal | Most views are missing artwork |
|
|
It was already raised as item 2) here: http://www.ventismedia.com/mantis/view.php?id=13562#c45820 . But it's probably useful to discuss separately here anyway. |
|
|
Some notes: 1) album artwork appears in A&D window, albums view, album view and in popups, where to search for artwork, if the option is set, only in album view and A&D window? 2) in case automatic search is not set and user searches for album artwork manually (right click on empty artwork - Find image), shouldn't we add also some "Save artwork to all tracks" feature? Otherwise the artwork is lost after closing the album view. Or should we save artworks to some temp folder and link them to album only? 3) should "Search for Missing Artwork automatically" affect also Artist image searching in artist view? Currently we search always for main artist image (if none exists yet) and save image to our Temp folder. The same for related artist lists, when the list is opened. And we do not search in Artists view at all. |
|
|
4) we cannot currently save artworks for online content (e.g. for online album added to library) |
|
|
1) I think that it should avoid _any_ online searches when this option is disabled. (But should be enabled by default) 2) Maybe could be saved automatically while showing a pop-up with an Undo button? (The action could be performed after the pop-up is hidden in order to avoid actually implementation of the undo action) 3) I think that this option should apply here as well (even though we might want to change the wording a bit). 4) Sounds ok to me. |
|
|
Note: please review 0013695 before implementing as it implies that: - Automatic Search/Lookup enabled --> images appear everywhere but Properties/A&D view - Automatic Search/Lookup & Save --> images appear everywhere The only possible issue with this approach is that if the same approach is applied to Lyrics, then they wouldn't appear in the A&D Window. We'll probably have to revisit this once we implement the Docked Properties dialog 0013406 --at that point we may want to consider that the A&D window shows images/lyrics even if not saved to the tag. |
|
|
3) I realized that _not_ searching images for Artist view doesn't make sense - we already download descriptions and leaving the image empty looks just weird. I wonder whether we should change wording of the Options somehow? |
|
|
3b) There's another instance of the issue: We currently _always_ look for lyrics in the new Lyrics panel and also in the Lyrics layout of the new Now Playing view. I think that in these instances it never makes sense to ask user for a confirmation whether to search, since based on the context user obviously _wants_ to see the data. That said, e.g. in A&D it would probably be a mistake to always search for lyrics? Rusty, please review. |
|
|
1) To review, there are 2 types of artwork: i) Artwork that represents what's in the tag: Properties dialog, Art & Details, ii) Artwork that is automatically looked up in order to assist with Navigation e.g. Album Art in: Albums view, Album view, Popups (although one could argue that images that appear in Albums view / Popups should reflect tags rather than auto-lookups). Artist Art in: Artists view, Artist view. So, perhaps: - If Auto-lookup is enabled --> category ii) of artwork should be automatically filled (?and saved? so that subsequent lookups of that type of artwork aren't required). - If Auto-save is enabled --> category i) of artwork should be automatically updated (i.e. the metadata should save to the tag) Note: one of the problems with the current UI is that there's no visual differentiation between the two types of artwork that appear in MM. I wonder if it would be possible to somehow make it more clear that A&D/Properties are the only artwork that is saved to a tag? e.g. if Artwork is in the 'lookup' database, then show it greyed out in the Properties dialog and A&D window and give the user a function to save the artwork to the tag. 2) If category ii) artwork is looked up manually, then it should be saved to the 'lookup DB' (but not to the tag). As Jiri described, some facility is required to edit that artwork (e.g. undo, or perhaps in the Find artwork dialog allow the user to choose a blank image if no others are satisfactory). Note: Re. saving of looked up artwork to a tag, this is described in 0013695 3) I suppose that Jiri's argument that it never makes sense to not look up images in Artist view could apply equally to not looking up Album images in Albums view (next to the album description). In which case, should we get rid of the option (i.e. always lookup this category of artwork)? The only reason why not to do this is if artwork is often incorrect, in which case some users would prefer that it not be looked up. 3b) The situation with Lyrics is similar to the situation with Album Art. i.e. Category i: represents what's in the tag Category ii: represents what's automatically looked up and saved to the 'lookup' DB ...and as described in 0013695 these two should always be consistent with one another. As with Art, it probably usually makes sense to lookup lyrics automatically, and to include the ability to save them to the tag. That said, I think we can keep the option to not look up lyrics since some users will be annoyed if incorrect lyrics fill up the screen. |
|
|
1) I wouldn't show the looked up (but not stored in tag) Artwork greyed out, but rather with a red '(i)' icon overlaid, with an explanatory text on hover and a confirmation dialog shown on click of this icon, something like: 'Would you like to store this Artwork to tag (or file)?' [Yes] [Yes, always] [No] 'Always' would turn the auto-save of found artwork option on. 3) I think that it makes sense to _not_ look up artwork automatically e.g. in the A&D window, i.e. an option for this seems to make sense. However, there are places where the lookup should be unconditional (like the mentioned header of the Artist view). So the question is, can we keep the current wording of the option? Isn't it confusing to disable lookups in Options and see them still working in some places? Maybe it's just about changing wording of the option? 3b) The same, it probably makes sense to let user to disable this search, but to _always_ search in some particular cases (like Lyrics NP view). |
|
|
1) You're right--using colors isn't very intuitive. We could use the exclamation point whenever the looked up metadata/artwork doesn't match what is currently stored (as with the auto-tag functionality). OR, I wonder if would be even simpler to just overlay a 'Save' icon in cases where the artwork isn't saved to the tag? 3) I was trying to say that album art should almost always be looked up for category ii) artwork (which is what I think you're saying as well), but that it shouldn't be shown for category i) artwork unless the user configures this (i.e. I think we're in agreement). 3b) Same as 3) Wording that would better reflect this approach: [ ] Look up missing lyrics --[ ] Update tags [ ] Look up missing artwork --[ ] Update tags |
|
|
1) Ok, either looks good, 'Save' seems to be easier to implement and understand. 3) Ok, we are in agreement here. |
|
|
Raised the priority of this to 'immediate' as it prevents verification of other bugs. |
|
|
Fixed in build 2076. Resolving so you can review what is still needed. Note, found Artist images are always saved in user folder for later use, so no "Save" icon needed here. Save icon for Albums means, that artwork is downloaded to temp folder, but is not saved to tag/file folder yet. |
|
|
Michal behavior Verified 2076 |
|
|
Tested build 2082 and there are a couple of issues: 1)A) If a particular AlbumName in Albums view is missing artwork when the user clicks it, and the artwork is looked up (automatically) in the Music > Albums > AlbumName view, then: i) the artwork will often fail to appear in the Albums view (despite the fact that it's stored within MM5 as evidenced by the fact that it appears in the Album>AlbumName view)! ii) The 'save' icon doesn't appear. B) Similar to Aii: Deleting Artwork via Properties... for all tracks in Albums>AlbumName --> Artwork is removed from A&D dialog, however, the Artwork is still shown in the AlbumName view but it's missing the 'save' icon! It's different than the previous case, though, in that this is just a refresh issue. 4) If Lyrics have been looked up but not saved, the 'save' icon should be presented. |
|
|
1)A, i) and ii) fixed in build 2083. 1)B) tracked in 0014469 |
|
|
Fixed in build 2083. (remaining 1)B) tracked separately as 0014469) |
|
|
Verified 2083 |
