0013695: Tools for editing artwork are inconsistent / redundant - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0013695	MMW 5	General	public	2016-11-28 23:15	2020-03-06 02:00

Reporter	rusty	Assigned To
Priority	urgent	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed

Summary	0013695: Tools for editing artwork are inconsistent / redundant
Description	Aside from the fact that Artwork displays inconsistently (as described in 0013562), the process of actually editing artwork in MM5 is incosistent and occasionally redundant because: 1) Album art for Albums view metadata section can be configured to be looked up automatically, but not saved (notwithstanding bug 0013579 in which these configs aren't working correctly), leading to a situation in which Artwork appears for the Album in Browser views, but not in the Albums view or the Properties and A&D Windows (as expected). In such cases, there's no mechanism to save this existing artwork from the metadata section (artwork is only automatically saved from Albums view metadata if the user _changes_ the artwork in the metadata section). The user must instead re-look up artwork in the A&D/Properties views using a different mechanism which may yield different artwork than what already appears in the metadata section. A solution to this could be to: a) Add 'Save image' as a context entry for the metadata image in cases where no image has been saved for the track. Note: The user would usually (for regular albums), but not always (for compilation albums) want to apply the image to all tracks on the album. So the 'Add image' dialog would have to be integrated to allow the user to choose. b) If the user clicks 'Lookup' in the A&D dialog: If artwork metadata exists but no artwork has been saved, MM should 'Lookup' the same art that already appears with the metadata section of the album (to avoid scenarios in which different artwork appears in the two artwork locations). Note: The should be integrated with the 'add artwork' dialog from 0013678 2) The mechanism for editing Artwork in the Albums view browser shows a dialog that lets the user select one of a group of automatically looked-up images. In contrast: - The mechanism to 'Look up' artwork in the A&D dialog is different (it just looks up art--no choice is given). In addition, it provides options to 'Paste' or 'Add image' that aren't availble in the Albums view. - The mechanism to add additional art is partial: i.e. to add art, the user can only Paste or Add Image (Lookup is not an available option). Note: the above ignores 'Auto-tag from Amazon' entirely, however, I think that's ok for now. A possible solution could be that: a) the commands for modifying artwork should be the same or at least similar in all locations. i.e.: Lookup image..., Add image..., Paste [OK] [Cancel] Alternatively, we could standardize on the 'Lookup image' dialog, but include within it options to 'Add image from file...' 'Paste other image'. b) in order for the same 'Add image...' dialog (see 0013678) to be able to apply correctly to all the different cases Album art metadata would have to be capable of storing > 1 image c) It would be useful if the 'Add image...' dialog had an option to: [ ] Replace existing image (disabled unless only a single image exists for all selected tracks. It should therefore appear below 'Apply to all tracks on the album.) This would allow for quick changes to artwork instead of forcing the user to Add and then remove artwork.
Tags	No tags attached.

Fixed in build	2071

michal 2017-06-27 11:33 developer ~0048278 Last edited: 2017-06-27 11:33	Mostly fixed in build 2071. 1a) 'Save image' will be solved with 0013579 - save icon. Standardized on improved "Image lookup" dialog with Browse button for selecting local image. I have preserved Paste (image) menu entry, because it would be better usable (no need to open search dialog for pasting image). "Replace existing" checkbox causes replacing image of the same type (only non-specified image can be replaced by Front cover).

peke 2017-06-29 20:32 developer ~0048295	Verified 2071

rusty 2017-11-09 06:03 administrator ~0049138	Verified 2082. Only issue is 2) Right-clicking on the image in Albums>AlbumName shows all of the context commands that apply to all of the tracks within the album. e.g. including Cut/Copy/etc.. I don't think that makes sense in this context (i.e. when the associated tracks are displayed but not selected) to perform contextual actions on unselected tracks. With that in mind I'd suggest that the only options that should appear over the album would be: Paste, Lookup image, Properties. Note: we may want to consider adding some of the context menus to the overflow menu in that view, but that would be a separate issue. 3) In the A&D Window, there's a context menu for Mode. I would suggest getting rid of that, unless there's a reason why it's needed.

michal 2017-11-09 08:13 developer ~0049139	re 2) it is related to 0014369

jiri 2017-11-09 09:36 administrator ~0049140	2) I think that having all that commands there is useful in order to execute a command on all tracks of the album (like e.g. Auto-Tag) without the need to select the tracks first. The idea is to make it consistent with e.g. Album+Tracks view - as described in 0014369. 3) There were some forum requests to offer other means of switching the mode than only the header click (which probably isn't obvious for everyone). So, we added it to the pop-up menu, as well as the overflow menu.

peke 2020-03-06 02:00 developer ~0057071	Verified 2229 Original bug is fixed.