View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001449 | MMW v4 | Properties/Auto-Tools | public | 2004-06-15 18:33 | 2007-09-17 09:28 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | feature | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0001449: AAC (m4p, m4a, mp4) Tagging support (failed scans / crash on scan) | ||||
| Description | Based on feedback we're receiving in the support forum, AAC tagging support is a _critical_ piece of functionality for a large number of users. Ideally this functionality will also work for ALAC tracks. Raisning to 'Urgent' for inclusion in 2.6--we need this even if we don't have an AAC playback plugin bundled with MM. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1075 | ||||
| has duplicate | 0002978 | resolved | jiri | Some m4a files fail to scan correctly |
| has duplicate | 0003051 | closed | jiri | Scanning networked files using a Vista machine doesn't work well |
| related to | 0001448 | closed | jiri | AAC (m4p, m4a) Playback Support (free) |
| related to | 0003134 | closed | Scanning M4P tracks crashes MediaMonkey | |
| related to | 0004917 | resolved | Ludek | MM can't read/write tag from some MP4 files (HEv2 AAC - Nero encoded) |
| related to | 0006382 | closed | michal | Tagging of large MP4 files takes too long |
| child of | 0000026 | resolved | rusty | Support Additional Tags |
|
|
I have been Investigated More futher and m4p, m4a, mp4 are iTunes proposal and solutions for AAC encoding. Which then classifies RAW AAC and AAC+ completly diffrent formats. I Making very good progress with reading m4p, m4a, mp4 with iTunes header. Note: Even Winamp have troubles reading of those file Tags. May I suggest that we for beggining make Reading of iTunes Compatible header and then see what other demands are. Playback is more simplier to make as all are based on same Header Type and Data stream structure. |
|
|
As discussed (with Peke), what is most critical is that we are able to read and write .m4a .mp4 and .m4p files that iTunes, which can be considered the cannonical implementation, writes and can read. As far as RAW AAC or AAC+ or New HEAAC or FAAC(FFMPEG) or 3GPP, .... I believe they are less strategic for now. |
|
|
As discussed with Peke and Pavel, this will become Pavel's task because it will be implemented in C f_aac plug-in that already can decode AAC tracks using QuickTime. Some interesting links: http://mpeg4ip.sourceforge.net/index.php http://www.hydrogenaudio.org/forums/index.php?showtopic=12075 http://search.cpan.org/~billh/ http://www.hydrogenaudio.org/forums/index.php?showtopic=39216&hl= http://sourceforge.net/projects/bento4 http://sourceforge.net/projects/atomicparsley http://developer.apple.com/documentation/QuickTime/QTFF/QTFFPreface/chapter_1_section_1.html#//apple_ref/doc/uid/TP40000939-CH202-DontLinkElementID_228 |
|
|
http://mp4ui.sourceforge.net/ could be interesting too. |
|
|
Documentation of atoms in Apple format (m4a, mp4, etc.): http://developer.apple.com/documentation/QuickTime/QTFF/qtff.pdf Useful links about AAC format: http://www.audiocoding.com/modules/wiki/?page=AAC - specifically: http://www.audiocoding.com/modules/wiki/?page=ADTS http://www.getid3.org/source/module.audio.aac.phps |
|
|
Tested build 1008 (although the bug isn't yet tagged as resolved) and noticed that: Tagging seems to function intermittently. e.g. if I rate 10 songs, the rating will be saved to the tag for 4-5 of them but not for the others. Same goes for the year field. Moreover, metadata doesn't seem to save for a large number of fields. |
|
|
Leave only these formats to be supported by the plug-in: AAC, M4A, M4B, MP4, M4P (maybe will be removed too?). QuickTime supports more formats, but we will be only able to fully support these (tagging, decoding using our (non QT) routines, etc.) |
|
|
Tested in build 1018 and found a number of critical problems with tagging .m4a files: 1) If the user tags tracks encoded with Nero Digital AAC (via DB PowerAmp), then the tracks become corrupted and are no longer playable in MM, Winamp, or iTunes. Note that prior to tagging, the track can be played in all 3 applications, and that iTunes and/or Winamp can tag such tracks without a problem. I've posted a sample track encoded by DB Poweramp using Nero Digital to the ftp server. The track is playable, but becomes unplayable after it is tagged by MM. Note: originally reported at: http://www.mediamonkey.com/forum/viewtopic.php?t=15403 2) Track number is not correctly read by MM (whether the tracks are encoded by iTunes or by dbPowerAmp). It is always scanned in as Track #1. 3) When editing tags, Original Year isn't saved, nor are any attributes in 'Details' (except for copyright) or 'Classification' or Lyrics. |
|
|
After this is fixed, Pavel should create a set of smaller files representing several possible versions of tags on m4a/mp4 files and upload them to FTP for testing. |
|
|
I've resolved critical problems with tagging .m4a files and posted a sample tracks to the ftp server for testing. |
|
|
Description of some frames in mp4 files: http://atomicparsley.sourceforge.net/mpeg-4files.html |
|
|
Reopening as Urgent issue to: 1. Document custom frames we use for tagging (not all frames were defined in mp4 tagging standard) 2. Tag album art ('covr') frame. It should be as complete as possible, i.e. support tagging of >1 cover per track and also hopefully links to external files. |
|
|
Another tagging problem reported in http://www.mediamonkey.com/forum/viewtopic.php?t=16006, raising to Immediate. |
|
|
Description of nonstandard tags, used in Media Monkey AAC plugin : +=======================+====================================+ | Tag | Desription | +=======================+====================================+ | publ | publisher | +-----------------------+------------------------------------+ | isrc | ISRC | +-----------------------+------------------------------------+ | lyrc | lyricist | +-----------------------+------------------------------------+ | cond | conductor | +-----------------------+------------------------------------+ | oart | original artist | +-----------------------+------------------------------------+ | otit | original album title | +-----------------------+------------------------------------+ | olyr | original lyricist | +-----------------------+------------------------------------+ | peop | involved people | +-----------------------+------------------------------------+ | oday | original year | +-----------------------+------------------------------------+ | empo | tempo | +-----------------------+------------------------------------+ | mood | mood | +-----------------------+------------------------------------+ | occa | occasion | +-----------------------+------------------------------------+ | qual | quality | +-----------------------+------------------------------------+ | cus1 | custom 1 | +-----------------------+------------------------------------+ | cus2 | custom 2 | +-----------------------+------------------------------------+ | cus3 | custom 3 | +-----------------------+------------------------------------+ | cus4 | custom 4 | +-----------------------+------------------------------------+ | cus5 | custom 5 | +-----------------------+------------------------------------+ | rate | rating | +-----------------------+------------------------------------+ | AApr | album art properties | +-----------------------+------------------------------------+ | AMIM | album art MIMEType | +-----------------------+------------------------------------+ | Adcp | album art description | +-----------------------+------------------------------------+ | Apty | album art picture type | +-----------------------+------------------------------------+ | replaygain_track_gain | track gain (foobar2000 compatible) | +-----------------------+------------------------------------+ |
|
|
Tested 1026 and there are still a couple of issues open: 1) Album Artist field isn't read in winamp, mp3tag, iTunes, although the info is saved to a tag that is read by MM (URGENT). 2) Track gain/album gain info doesn't seem to be tagged. It's not read by MediaMonkey or Winamp, and MP3Tag only shows ITUNNORM and ITUNSMPB fields (URGENT). 3) Album Art not read in MP3tag or iTunes for tracks encoded by DBPoweramp (urgent) 4) All custom fields not visible in MP3tag. Shouldn't they be visible? 5) Tags don't save for Mood, Tempo, Quality, Occasion, custom fields. |
|
|
Also the following field names should be changed, the 'id' prefix was originally used as IDs were used (incorrectly) but now it doesn't make sense: +------+----------------------+ | tmpo | tempo | +------+----------------------+ | mood | mood | +------+----------------------+ | occa | occasion | +------+----------------------+ | qual | quality | +------+----------------------+ |
|
|
Also, can you please document the tags being used for Standard fields as well? |
|
|
There is a very serious problem: scanning fails on some files, followed by AV (probably visible in debugging environment only - e.g. Delphi), but causing that tags and track length aren't read from files and probably also other scanning problems reported in forum. Uploaded 01_Finger_Poppin_Time.m4a to FTP. |
|
|
Description of standard tags, used in Media Monkey AAC plugin : +======+========================+ | Tag | Desription | +======+========================+ | ©nam | Title | +------+------------------------+ | ©ART | Artist | +------+------------------------+ | aART | Album Artist | +------+------------------------+ | ©alb | Album | +------+------------------------+ | ©gen | Genre | +------+------------------------+ | gnre | Genre | +------+------------------------+ | ©cmt | Comment | +------+------------------------+ | cprt | Copyright | +------+------------------------+ | ©day | Year | +------+------------------------+ | ©wrt | Composer | +------+------------------------+ | ©lyr | Lyrics | +------+------------------------+ | trkn | Track number | +------+------------------------+ | disk | Disk number | +------+------------------------+ | tmpo | BPM | +------+------------------------+ | covr | Artwork | +------+------------------------+ |
|
|
Reopenning in order to add new fields: - Album Gain - Custom4 and Custom5 - Date (full date, not only year) |
|
|
Reopenning since several users have reported that just some 25% of their tracks are scanned. Confirmed that a sample track "10 Wandering Spirit.m4a" isn't scanned by MM, the track is uploaded to FTP. Also track "03 Velvet.m4a" from another user is uploaded to FTP. |
|
|
Aside from failed scans, there's another problem: scanning some .m4a tracks causes MM to crash. I've uploaded 3 such tracks to the ftp server: 01 Girldfriend.m4a 01 Stand.m4a 02 I can do better.m4a |
|
|
Build 1037 doesn't seem to crash on XP, but it does crash on Vista when scanning the files in the 'The Tragically Hip' directory. Both the directory, and a log are posted to the ftp server. |
|
|
To make it absolutely clear, I uploaded to FTP track 'Motorhead - Motorhead.m4a' created by f_aac_codec.dll plug-in. Reading or writing tags always fails on this file. |
|
|
Reopenning since it still doesn't work well, there are AVs thrown, some tracks can't be tagged, etc. - mainly reproducable on tracks created by f_aac_codec.dll. |
|
|
Crash is reproducible with the Tragically Hip directory. |
|
|
Fixed in build 1039. |
|
|
Verified 1039. |
|
|
Need to add support for 'Grouping' (see 0003258). |
|
|
This should be done using '©grp' field. |
|
|
Fixed in build 1075. |
