View Issue Details

IDProjectCategoryView StatusLast Update
0016606MMW 5Tagging / organizing (properties / auto-tools)public2020-05-19 01:36
Reporterrusty Assigned To 
PriorityurgentSeveritycrashReproducibilityalways
Status closedResolutionfixed 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0016606: Image Lookups are delayed / result in crashes
DescriptionWhen the user looks up an image in the Properties dialog, the image lookup can take up to 20s and can trigger a crash. e.g.
1 Select a track, click Properties > Artwork Tab
2 Lookup image (in order to add a second image)
3 Select an image and click ok
--> It can take 20+ seconds for the Add Cover dialog to appear (the video at 0016120:0057989 (at around 1:20) illustrates this)
4 Close the Lookup Image / Properties dialogs before the Add Cover appears
--> After a bit more of a delay, the Add Cover may appear (despite the fact that the Look Image / Properties dialogs are closed)
5 Cancel out of Add Cover dialog
--> Crashlog: A04C2D48

TagsNo tags attached.
Fixed in build2250

Activities

michal

2020-05-13 16:18

developer   ~0057991

The Add Cover dialog delay is caused by downloading the original image. It is not always possible to download every found image (at first we display only thumbnails from Google cache), so we download it before allowing saving to the tag. I'll add some progress info during the download, so it is clear, what is going on.
Bug report received.

michal

2020-05-15 16:48

developer   ~0058050

Fixed in build 2249.

rusty

2020-05-17 02:52

administrator   ~0058066

Tested 2249. The crash no longer occurs, however, the workflow still doesn't make sense. Here's what currently occurs:

1 Select a track, click Properties > Artwork Tab
2 Lookup image (in order to add a second image)
3 Select an image and click ok
--> It takes some time for the Add Cover dialog to appear
4 Close the Properties dialogs before the Add Cover appears
--> After a bit more of a delay, the Add Cover dialog still appears (despite the fact that the Properties dialogs is already closed)!
--> This doesn't make sense especially because the dialog has an 'OK' button to accept the new artwork, but it doesn't actually do anything (because the Properties dialog has already been closed)!

This is a minor issue, but what should happen is that once the user cancels out of the Properties dialog, the 'Add Cover' dialog should never appear.

michal

2020-05-18 08:07

developer   ~0058082

Fixed in build 2250. It was harder to reproduce on my PC (it needs to hit very specific timing), but should be ok now.

rusty

2020-05-19 01:36

administrator   ~0058102

Verified 2250.