View Issue Details

IDProjectCategoryView StatusLast Update
0004397Last.fm pluginLast.fmpublic2013-12-10 00:48
Reporterrusty Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status closedResolutionwon't fix 
Summary0004397: Last.fm DJ
DescriptionMM should have an Auto-DJ extensions that generates music recommendations based on last FM, to go along with the Last fm scrobbler.
TagsNo tags attached.
Fixed in build

Relationships

parent of 0004897 closedpeke Last.fm plugin Last.FM DJ problem handling Regional Decimal separators 
related to 0004407 resolvedLudek MMW v4 Auto-DJ adds multiple identical tracks in some cases 
related to 0004518 closedpeke MMW v4 Last.fm Extensions: uninstall doesn't work correctly 

Activities

rusty

2008-02-14 16:34

administrator   ~0013115

Last edited: 2008-02-14 16:34

Recommended changes for build 2.0.0.20
-Filename: LastFMScrobblerDJ.mmip --> Last.fm_DJ.mmip
-Product Name: Last.FM ScrobblerDJ --> Last.fm DJ
-Description: Last.FM ScrobblerDJ (AutoDJ Script) --> Creates Auto-DJ Playlists from the Last.fm music recommendation service
-Product Type: script --> Auto-DJ Script

Info shown: --> this config is not required in the UI--just set it to a default of 5 sec

Based on discussions, here is the recommended UI layout including recommended defaults.

-----------------------------------------------------------------------------------------------
Last.fm DJ Options
-----------------------------------------------------------------------------------------------
This Auto-DJ extension will automatically add Tracks to the Now Playing list based on which 
Artists are most similar to the last Track in the list. The recommendations are based on the 
Last.fm music recommendation service.

Recommendation Criteria:
Artist Similarity:           _60_ %
Delay Tracks by Same Artist: _60_ minutes
Minimum rating:              _**___
 [x] Allow unknown rating

If no recommendation is available:
Keep trying for:             _60_ seconds
Then use backup Playlist:    _Favorites..._______
 [ ] Display warning
 [ ] Save logs

                                                                                [OK] [Cancel]
-------------------------------------------------------------------------------------------------


rusty

2008-02-14 20:53

administrator   ~0013117

Last edited: 2008-02-14 21:46

Based on discussions with Peke, here's revised UI proposal:
------------------------------------------------------------------------------------------------
Last.fm DJ Options
------------------------------------------------------------------------------------------------

This Auto-DJ extension will automatically add Tracks to the Now Playing list based on which
Artists are most similar to the last Track in the list, and on which Tracks are most popular.
The recommendations come from the Last.fm music recommendation service.

Track Recommendation Criteria:
Artist Similarity: _60_ %
Delay Tracks by Same Artist: _60_ minutes

If Recommended track is unavailable, use alternate by same Artist:
Track Rating: _>=_ _**___
 [x] Allow unknown rating

If no recommendation is available:
Use backup Playlist: _Favorites..._______
 [ ] Display warning
 [ ] Save logs

                                                                                [OK] [Cancel]
--------------------------------------------------------------------------------------------------

Progress Message Changes:
-Scrobbler DJ: Querying Last.FM...
--> Querying Last.fm...

-Scrobbler DJ: Could not access Last.FM, check network connectivity or Last.FM web page status :-( .... ScrobblerDJ will add a track from the default playlist
-->Last.fm DJ could not access Last.fm, check network connectivity or Last.fm web page status. Adding a track from the backup Playlist.

-Scrobbler DJ: Could not locate artist on Last.FM :-( .... ScrobblerDJ added a track from the default playlist
-->Last.fm DJ could not locate artist on Last.fm. Adding a track from the backup Playlist.

-Scrobbler DJ: Unable to add tracks, even from your default playlist :-(... Seems like you don't have enough accesible tracks
-->Last.fm DJ unable to add tracks...there aren't enough accessible tracks.

-Scrobbler DJ: Artist located on last.fm but either none of its related artists were found in your library or your settings are too tight :-( .... A track from the default playlist was added
-->
Last.fm DJ located the Artist Last.fm but no related Artists were found in your library or your settings are too restrictive. Adding a track from the backup Playlist.

-Scrobbler DJ: Suggested Artist <" & iArtist & "> located in your Library but none of his top tracks did, perhaps your settings are too tight :-( .... Scrobbler added one of the Artist's tracks you own
-->Last.fm DJ located the recommended Artist <" & iArtist & "> in your Library but none of the recommended tracks. Adding random track by <" & iArtist &">.

NOTE: I don't understand the above error message. As far as I understand, there are no restrictions on Top tracks that are found in the library (the only possible restriction is Rating, however, you'd indicated that Rating Does_not_ apply to Top Tracks--and that it only applies to tracks that are chosen randomly after a matching artist is found).

peke

2008-02-15 22:17

developer   ~0013141

All updated.

Created SVN Folder for scripts

Latest MMIP sent to you

peke

2008-02-15 22:18

developer   ~0013142

You must firstly uninstal Older Script before install this one.

rusty

2008-02-17 07:07

administrator   ~0013146

Tested v 2.0.0.21 (from Petr) and as soon as I click the Configure button to set the Auto-DJ options, I receive the following error:

Error
Error #424 - Microsoft VBScript runtime error
Object required: 'edt'
File: "C:\Program Files\MediaMonkey\Scripts\Auto\LastFM_DJ.vbs",Line: 1110, Column: 4

Note: I tested both the build from Petr and Peke, and both exhibited the same issue. Also, I had uninstalled MM and manually deleted any plugins remaining in the plugins directory prior to installing the plugin. When the plugin failed, I tried uninstalling by deleting the plugin via the Extensions panel and completely deleting MM's ini file, and then re-installing, but the error persisted.

peke

2008-02-17 11:23

developer   ~0013151

There was small Typo in release I updated SVN

rusty

2008-02-18 02:13

administrator   ~0013164

Last edited: 2008-02-18 03:10

Tested 2.0.0.22. A couple of additional minor changes should be made:

1) Too much text in the intro. Delete 'To get involved in this community, try downloading the MediaMonkey LastFM plugin.'

2)
i) If rating of '*****' is chosen, then <= can't be selected (it's locked to >=, but it should be possible to select = or <=)
ii) Rating 'None' should be changed to 'Unknown'
iii) If rating of 'Any' or 'Unknown' is selected, the modifier should automatically be locked to '='.

3) The plugin behaves very badly if:
i) the Auto-DJ is set to add > 1 track. e.g. by default, MM is set to add 5 tracks, however, with this default setting, the Auto-DJ often adds multiple identical tracks in a row. How can we fix this?
ii) if the Auto-DJ selects a track that a user doesn't like, the user can click the 'next' button to skip the track, however, what typically happens then is that the auto-DJ adds that same track again. How can we fix this?

4) Please do a search of the source to ensure that the name is properly described as Last.fm DJ (I noticed a warning in which Scrobbler DJ still appeared).

5) Sent Elog re. error that was somehow triggered by the script. What happened was the Auto-DJ was generating recommendations from Last.fm and then just stopped doing so. I clicked Tools > Options, and the error occured. This should be resolved as well.

peke

2008-02-18 03:42

developer   ~0013166

1) Fixed
2) i) I have Unlocked Rating Condition to be changeable if ***** is selected Selecting >= will Act same as = as there is no way to disable just one option from Dropdown.
   ii) Fixed
   iii) Doesn't affect whatever is set to Rating Condition and it is ignored in Search that is why it is disabled. reason why this do not change in view is to have some sort of previous setting saved.
3) This is Bug Internally in Auto-DJ and Can be easily reproduced with every Auto-DJ script not just Last.fm DJ. This Needs to be handled in Separate BUG.

4) I searched complete "LastFM_DJ.vbs" and no "Scrobbler DJ" is found, but just in case I have deleted Commented Hints so that they do not make confusion.

rusty

2008-02-18 17:03

administrator   ~0013170

Last edited: 2008-02-18 17:53

Verified most items in 2.0.0.23, except:

2.iii) This is still an issue--it's confusing for the UI to show '>= unknown' or '</ Any'. It should either show '=' for these cases, or the '=,>=,<=' dropdown should be greyed out for these cases.

6. After using the script some more, I've found that it sometimes adds 2 identical artists in a row (I'm guessing that this is because the second artist gets added before the first completes playing).

7. It sometimes even adds the same artist 3 times in a row even when it is configured to not do so for 60 minutes. This implies a different problem than item 6, since in this case, item 1 has already completed playing when item 3 is added.

I'm moving item 3 to a separate bug.

peke

2008-02-19 10:33

developer   ~0013180

2) iii) I'll make it that way then Rating Condition will be changed according to Selection of Rating for the time being. >= is not grayed out du to Thene engine even [v] is grayed. Suggestions?

6) and 7) I'll see if it is some sort of related to Play counter and when MM write Last Played Value.

3) Agreed. Will follow up that Bug.

peke

2008-02-20 04:19

developer   ~0013187

Bug in Announce Thread is fixed in 2.0.0.24.

Last.fm DJ now load Rating Conditions correctly

peke

2008-02-22 08:30

developer   ~0013193

As user in forum note it would be useful if we add one more option to Recommendations:
[] Ignore Top Track Recommendation

Option will ignore top tracks and will use Alternate from same artist.

I think it adds some fun in Last.fm query and is certainly useful if you want to see if there is some other tracks from recommended artist you haven't heard and that is not Top Track.

rusty

2008-03-28 04:06

administrator   ~0013517

Auto-DJ Bugs:
1) Ratings config problems:
a) I am unable to set the configure to "<=" or "=". When I change in the configure option it goes right back to ">=". FIXED?
b) It's confusing for the UI to show '>= unknown' or '<= Any'. It should either show '=' for these cases, or the '=,>=,<=' dropdown should be greyed out for these cases.
c) The ratings option is not exact (user indicated that Star ratings don't match correctly to the values used in the DB). I have not confirmed whether this is an issue.

2) "Delay Tracks by Same Artist" doesn't work at all sometimes. Script will add 2 identical artists in a row!
e.g. I keep getting multiple recommendations of the same song. I.E. I play Orphans of Sickness from Gorguts, then it recommends:
To Breath in A Casket - Necrophagist
To Breath in A Casket - Necrophagist
Shine of Consolation - Lykathea Aflame
To Breath in A Casket - Necrophagist
Shine of Consolation - Lykathea Aflame

3) Non-english users get a "default playlist doesn't exist" error because the playlist is hardcoded text. We should change the textbox to a dropdown control, and select the first playlist if the Top50 playlist doesn't exist.

4) .vbs-error when it says "last.fm query". The error message is "no correspondanse between types: CInt. File ... lastfm_DJ.vbs, line 540, column 8"

5) The 'Configure' Button blinks (changes between visible and invisible) reported on german version. I have not observed this and cannot reproduce.
6) Go into tools / options / autodj and click configure, even if I cancel out without doing anything, the autoDJ stops working. I cannot reproduce this, but noting it here in case you see a reason for this.

Missing Features:
7) Ability to prevent same titled songs in succession.
8) Include (/Exclude) tracks from filter/playlist (e.g. year < 1990)
9) Ignore top recommendations

Suggested UI appears below. Note that the UI implies some change in the logic of the plugin since 'Restrictions' are _always_ in effect.

-Recommendation Criteria------------------------------------------
| Last.fm Artist Similarity: __
| Last.fm Track Rating: _Top-rated/any_
|
| If Top-rated track is unavailable or unwanted use
| Local Track Rating: _>=_ _***__
| [x] Include Unknown Rating
|
| [x] Only use tracks from _Playlist/Filter_^: _<Playlist>__^
-------------------------------------------------------------------

--If no recommendation is available--------------------------------
| Use backup Playlist: _____________________^
| [ ] Display warning
| [ ] Save logs
-------------------------------------------------------------------

--Restrictions-----------------------------------------------------
| Delay Tracks by Same Artist: __ Min.
| Delay Tracks with Same Title: __ Min.
-------------------------------------------------------------------