View Issue Details

IDProjectCategoryView StatusLast Update
0004518MMW v4Framework: Scripts/Extensionspublic2008-11-27 05:19
Reporterrusty Assigned To 
PriorityimmediateSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version3.0 
Summary0004518: Last.fm Extensions: uninstall doesn't work correctly
DescriptionFor both the last.fm scrobbler, and last.fm Auto-DJ, uninstalling the extension doesn't work. i.e. after restarting MM:
-the options menu for the scrobbler remains
-the auto-dj panel still contains the last.fm-dj options along with the full menu.

Is this a problem with these plugins? or a problem with the framework?
TagsNo tags attached.
Fixed in build1186

Relationships

related to 0004397 closedpeke Last.fm plugin Last.fm DJ 
related to 0003844 closedpeke Last.fm plugin Last.FM Native Support 
related to 0004869 closedpeke MMW v4 Extensions.ini - values including '=' are not written correctly 
related to 0004865 closedjiri MMW v4 CoClass SDBFileSystem Do not have MoveFile VBScript feature 
related to 0004866 closedLudek MMW v4 Extension install / unistall issues (.ini file handling) 
related to 0004867 closedLudek MMW v4 Installation of extension can't be aborted 

Activities

jiri

2008-04-02 22:46

administrator   ~0013592

It's a problem of these MMIPs, assigning to Peke to fix.

peke

2008-04-02 23:00

developer   ~0013593

Last edited: 2008-04-02 23:02

- last.fm DJ Uninstall Fixed v2.0.0.25

- Scrobbler not yet fixed as Core framework of loading/unloading plugins needs to be solved. as MediaMonkey Currently can't Uninstall/Unload any DLL loaded on startup
Possible solutions would be to either:
a) make Uninstall of General Winamp Plugins (same routine we use on shutdown)
b) make some additional flags which will let MM to uninstall plugin.
c) make some sort on Startup uninstaller

Assigning to Jiri for deciding what would be the best and with less risk.

jiri

2008-04-03 22:09

administrator   ~0013633

That's right, it isn't currently possible to dynamically unload the dll and due to possible problems I'm not sure if it ever will be. That said, the uninstaller still should:

1. Remove LastFMOptions.vbs script.
2. Since the dll can't be deleted, it could be at least renamed, so that it isn't loaded the next time MM starts. I.e., it could be renamed to something like gen_LastFMScrobbler.dll.off. Note that it can't be done directly in uninstall.ini, but it should be easy to implement by calling uninstall.vbs.

peke

2008-07-08 22:10

developer   ~0014333

For now until we figure out way to solve Uninstall of General plugins suggested will be good as workaround.

Note: Winamp 5.5 supports uninstall of general plugins and as tested on my dummy Genral plugin it is done this way:
1. execute plugins Quit Command (same quit is sent to plugin on app exit)
2. Unloads DLL
3. deletes DLL

peke

2008-10-01 03:31

developer   ~0014684

Made workaround regarding Uninstall of last.fm scrobbler but due to bug 0004866 reinstalling over the top of existing plugin requires 2 MM restarts

peke

2008-10-03 01:17

developer   ~0014702

Reopening to reflect fixes in 0004866

rusty

2008-11-27 05:19

administrator   ~0015171

Verified.