View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004867 | MMW v4 | Framework: Scripts/Extensions | public | 2008-10-01 02:28 | 2022-04-29 01:48 |
| Reporter | peke | Assigned To | |||
| Priority | high | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 4.0 | ||||
| Summary | 0004867: Installation of extension can't be aborted | ||||
| Description | Currently there is no way to abort installation of extension by either MM UI or with internal results from executing scripts by using [Execute] Sections in install.ini | ||||
| Tags | todoc-dev | ||||
| Fixed in build | 1300 | ||||
|
|
Example: currently you can't abort installation of extension if new version needs that all previous installed versions are uninstalled. If installation Script Install.vbs searches for existence of SDB.Tools.FileSystem.FileExists(SDB.ApplicationPath&"Scripts\Auto\LastFM_DJ.vbs") and need to abort installation it can't be done currently |
|
|
2. As in case of new last.fm scrobbler plugin I think that installation package should end Installation message. Current behavior: "To complete installation please restart MediaMonkey!" -> OK -> "Installation Completed Successfully" -> OK I think that there is no need for second Info. |
|
|
I guess that it would make sense to add an error code as a result of executing a VBS function (optionally). In case the function would return non-zero result, the installation would be aborted. |
|
|
Fixed both 1) and 2) in build 1300. i.e. If you use Function instead of Sub and return: 0 - nothing is changed 1 - the "Product Installed Successfully" message will not be shown * - anything else except for 0 and 1 will result in "Product Instalation Error" message and installation will be aborted (same as for UnInstall process that can be aborted this way too) @Peke, tested on your LastFM script and works fine, is it sufficient? |
|
|
Yes it is. Is 0 default value if function result is missing? |
|
|
yes, 0 is the default, if the 'Sub' is used instead of 'Function' |
|
|
Verified 1334 |
