View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007901 | MMW v4 | Main Panel | public | 2011-05-30 16:59 | 2011-06-03 17:17 |
| Reporter | lowlander | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.0 | ||||
| Target Version | 4.0 | Fixed in Version | 4.0 | ||
| Summary | 0007901: Art Browser/Column Browser limits Media Tree node context menu to shown Album | ||||
| Description | When enabling the Art Browser the active Media Tree node's context menu only operates on the Album shown in the Art Browser instead of all the Media Tree node's content. This means that when the Art Browser is enabled the user can't add the whole Playlist to the Now Playing, it will only add the selected Album's tracks. | ||||
| Additional Information | http://www.mediamonkey.com/forum/viewtopic.php?f=10&t=58264 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1383 | ||||
|
|
Interesting, I'm not sure it's a bug though - I think that both approaches, i.e. to operate on all content and on the filtered content only make sense. Therefore, I'd probably just left it as is. Note that the same situation is for Column Browser. |
|
|
I disagree, I would expect that any Media Tree node context would work on all node content and not on filtered content. Now a user would need to disable the AB/CB to be able to add all tracks to the Now Playing and then re-enable AB/CB. If the user only wants to operate on the shown tracks the user can just select the shown tracks instead of using node context so it's not needed that the Media Tree node context adheres to filtering. |
|
|
I think that LL's point is valid -- it's actually kind of similar to item e) (selection / context menu issues) described at 0003636: The album browser should i) allow albums to be selected and right-clicked ii) allow albums to be double-clicked This bug extends that idea to multiple selection: iii) it should be possible to select multiple entries in the Art Browser when focus rests on the art browser. Note: this issue isn't nearly as noticeable in the Column Browser because: ii) selections can be double-clicked iii) 'All' is selected by default, so the user can just right-click on any tree node to perform an action on all of the tracks. Such an option isn't available in the Art Browser. One way of ameliorating this would be to make the first entry an 'All' entry (when multiple Albums exist), but that would probably be pretty ugly. The simplest solution would be to fix items i) and ii) described in 0003636 and allow for selection of multiple Images in the Art Browser. |
|
|
Just to clarify I'm talking about the Media Tree node's context menu, not about the Filelisting/Album Browser/Column Browser. |
|
|
I understood the root bug that you were raising to be the fact that "when the Art Browser is enabled the user can't add the whole Playlist to the Now Playing, it will only add the selected Album's tracks." The solutions that we proposed to this bug are different, though. You proposed that the Tree context menu should ignore what tracks are filtered, whereas I proposed that MM should continue to have context operations apply only to the filtered file list, but that there should be a mechanism for selecting multiple/all albums so as to solve the root issue. So if the content in the tracklist is only a single album (because only 1 album is selected in the Art Browser) then the context menu should apply to that single album. But there should be a mechanism for selecting more than one album and in such a case, the context menu (in the tree, and in the Art Browser itself) should apply to all of the selected albums. But if this is the approach we decide on, perhaps we should just close this issue, and add point e) iii) 0003636: iii) it should be possible to select multiple entries in the Art Browser (with possible approaches being multiple selection or use of an 'All' entry). |
|
|
First of all I don't see why the node needs to behave filtered at all. If the user needs to perform an action on filtered tracks it can already be done by selecting the track. If the users needs to do an action on all files the user needs to jump through hoops to get to all files instead of filtered files. Neither is it consistently implemented as when you Cut & Paste a location node that is filtered it will Cut & Paste all files and not the filtered ones. |
|
|
I see your point. My key issue is that it would be confusing to users if they right-clicked on a node and it resulted in an action on files that aren't visible. This is currently a problem only: 1) When Art Browser is enabled 2) When Column Browser is enabled in the specific case when a user filters the list and right clicks on the _same_ node as is already selected. To work around this: 1) Art Browser: Upon selection/right click on a tree node, the Art Browser should open in such a manner that All Albums are selected (e.g. none are displayed larger than others), so that all tracks in the node are displayed. 2) Column Browser: If a filter (other than 'All') is active, then upon clicking the tree node, the Column Browser filters are automatically reset to 'All'. With the above changes, actions on a node will always be performed on all of the tracks in the node, and the user won't be surprised at this. |
|
|
I personally don't see the need to select all files, but it will solve the problem. You'll probably get users complaining their filtering is lost after right click on node though. I do wish as earlier reported that left click on active node would reset filters. |
|
|
I reviewed this with Petr, and he indicated that this is going to cause a performance problem for the Art Browser view (e.g. in a 100k collection right click on Play Now will require looking up all tracks, getting art, and collating into albums). His recommendation is to consequently defer this for now. |
|
|
As further discussed offline, we are able to implement this without any performance issues. To be implemented: 1. Left click on the active node will reset any active filters (or do nothing in case of no filtering). 2. Right click on the active node will not reset the filter - i.e. no change here. 3. Art Browser will support showing of all albums and will start be default in this mode. |
|
|
Implemented in 1383 |
|
|
Verified in 1383. |
