View Issue Details

IDProjectCategoryView StatusLast Update
0006529MMW v4Main Panel/Toolbars/Menuspublic2011-09-21 23:29
Reporterrusty Assigned To 
PriorityhighSeverityfeatureReproducibilityalways
Status newResolutionreopened 
Product Version4.0 
Target Version4.1 
Summary0006529: Right-click on nodes selects content, interfering with 'Open in new tab' function
DescriptionRe. a) The 'Open in new tab' functionality cannot be added for all nodes until it's possible to right-click a node without selecting its content--otherwise two tabs of the node appear.

Note: in 6505 a hack is suggested to allow right-click of a node to not select the nodes' content for root nodes (except the CD and Devices nodes), however, that's inconsistent, in the sense that only some root nodes work this way, and in the sense that the function can be used if the user is deeper in the tree.

Opening this bug for Petr/Jiri to review and decide on the best approach.
TagsNo tags attached.
Fixed in build

Relationships

related to 0006505 closedpetr Tabs 
related to 0006589 closedpetr Context commands missing on root nodes 
related to 0007901 closedpetr Art Browser/Column Browser limits Media Tree node context menu to shown Album 
parent of 0007368 closedjiri Custom node should not be selected and OnFillTracks event should not be fired with right-click on node [MM4] 
related to 0007253 closedLudek 1345: Search issues 
related to 0007296 closedpetr Click middle button should open new tab for the node that is currently hovered over 
related to 0007367 closedpetr Right-clicked tree node is not highlighted [MM4] 
related to 0007409 closedpetr Options > Edit Collection edits the wrong collection 
child of 0005041 new right click on tree node show it's content in library 

Activities

petr

2010-10-09 00:12

developer   ~0020687

I've implemented that so let's see and give a feedback. Will be in 1315.

jiri

2010-10-18 20:47

administrator   ~0020839

To summarize our options, we can:
1. Use the hack as implemented as of build 1315.
2. Implement non-focusing right-click on the main tree.
3. Leave it as it was in previous builds, i.e. right-click would always focus tree nodes.

I don't like 1. much, since it isn't consistent and as such it's probably inferior to any solution. 2. might be quite a good solution, but there are some reasons why not to use it:
a) Some users (if not many) are probably used to the current way it works and wouldn't like any change. We could add an option for this, but then it would be just one more option to maintain.
b) Technically it's not a completely trivial change, it's possible to implement, but there could be quite a number of regressions.
3. Is quite good, but 'Open in a New Tab' right-click menu item doesn't make much sense there, since it actually only doubles the newly focused tab.

Given all this, I'd prefer to use 3. and consider usage of 2., either for 4.0 final, in case there is a strong demand, but probably rather for some later version, when we decide how would this work on all platforms (i.e. Mac, etc.).

rusty

2010-10-19 01:10

administrator   ~0020851

I'd prefer to leave as is (option 1), but limit the 'Open in New Tab' functionality to those nodes in which the hack has been implemented (i.e. root nodes). That way, the inconsistency is limited to a couple of nodes.

From my perspective, the behavior of option 3 from previous builds was so odd as to be useless--why would there be a need to 'Open in New Tab' if performing that operation opened the node in the current tab as well!!!

jiri

2010-10-19 18:43

administrator   ~0020866

As discussed over IM, we'll consider this solution (1) as good enough for now and based on feedback will think about (2) for the future.

rusty

2010-10-28 04:55

administrator   ~0021041

Last edited: 2010-12-21 18:28

Re-opening for long term fix (item 2) since the hack is just a hack and we may not be able to retain it for MM4 because it's resulted in some relevant context commands being hidden.

This needs to be properly fixed by making right-click not select content.