View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009578 | MMA | Navigation | public | 2012-08-14 19:48 | 2012-10-13 01:43 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 1.0.1 | ||||
| Summary | 0009578: Jellybean: context menus don't display as expected | ||||
| Description | In Android 2.3, the context menu displays by clicking the HW options button (as expected). In Android 4.1, though, the context menu is _always_ displayed at the bottom of the tracklist, wasting screen real estate. What should happen is that the menu items should be triggered via 3 vertical dots next to the search bar (at least that's how it works in other apps on Android 4.1). | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 26 | ||||
| related to | 0009549 | closed | rusty | Adjust action bars to different screen sizes |
| related to | 0009813 | closed | rusty | Overflow (Options) missing from Menu bar (regression) |
| related to | 0009408 | closed | marek | Implement Select All button for context selection mode |
| related to | 0009389 | closed | jiri | Consistent context action bars |
| related to | 0009596 | closed | marek | Player bar should show additional controls if space is available |
|
|
Another problem is that in the horizontal layout, when in Selection mode, Select All button isn't visible. |
|
|
I will add a summary from mail discussion about showing bottom action bar on devices with or without HW keys: 1. Phones without HW Options key: a. Devices with a limited screen estate: Action bar contains only Overflow icon, which opens a pop-up menu with commands like Seach, Options, etc. b. When enough space is available, then more actions are directly on the Action bar, not only Overlow, but also Search, etc. 2. Phones with HW Options key: - Do the same as in 1., and pressing the HW Options key would do the same as pressing the Overflow icon, i.e. open a pop-up menu. |
|
|
A clarification re. 2.: Overflow icon shouldn't be shown at all in this case, since it's replaced by the HW button and would only occupy a space in the Action bar. Note that several Google applications have the very same approach, e.g. Gmail, Galery or Play Store. |
|
|
Removed additional action bar - menu is displayed as popup window for devices with HW menu key - menu is displayed under overflow icon for devices without HW menu key |
|
|
This is mostly fixed, but there are still a couple of bugs: 1) Portrait mode, HW options key shows 'Options' but it appears very strangely--in a little box covering the left half of the player menu. I'm not sure of a better alternative, but it looks strange. 2) Multi-Select in Landscape mode. a) The the 'Select all' tool doesn't appear. b) If tracks are playing, then the context buttons partially cover the miniplayer (strangely, this only occurs on a phone--on the nexus 7, the miniplayer was hidden, but on the phone the miniplayer continued to display) 3) Multi-select (Landscape or Portrait). Even when space is available for additional icons, the overflow menu appears instead of displaying the icons. |
|
|
1) Well, also standard menu in others apps shows here ( some lines alligned to bottom). The only difference is in allignement. I can improve it by moving the menu above the miniplayer. Pls let me know. 2) a) added b) well I figured out that the overflow icon is transaprent. So if the name of track is long enough, it is visible even in contextual mode, i.e. usualy on small screens - phones. So I changed the background. 3) I optimized it for "Normal" and "Large" screens. I changed it to 3 main icons, 5 contextual icons in portrait mode and 3 main icons, 3 contextual in landscape mode. This capability should be tested on other phones and the numbers should be adjusted. I can get the size of phone from our logs, but I don't know the counts of icons. We can implement some mechanism to do it automatically in the future... |
|
|
Tested build 26: 1) OK, not worth spending time on this. 2a) Works, but the button appear in the correct location. It should appear directly above the checkboxes, but it doesn't even appear close to them, making it completely non-obvious what it does. 2b) OK that problem no longer exists. Btw, is it intentional that the Pause/Next buttons of the miniplayer don't display in landscape mode? 3) Looks good on the devices that I'm using. |
|
|
2a) ok. So you think, it should be on position of overflow? But overflow should be there. I can move overflow one position to the left. 2b) Yes, it is intentional. The bar is shorter than in portrait mode, so I removed the controls. It can be easily added if there is big devices where controlls can be shown even in landscape. |
|
|
2a) I suppose there's no way to fix this. The best workaround will be to change the 'select all' icon so that it's more self explanatory (described in 0009581 ). 2b) Yes, for larger devices, I think it would make sense to display the play/pause buttons. I'll enter a new bug. |
|
|
Verified 27. |
